Recognize X100 bikes as VirtuFit Etappe 2.0i - #4906
Merged
Merged
Conversation
Owner
Author
|
Mail baswilberink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
X100-Bluetooth name to the existing VirtuFit Etappe 2.0i behavior so X100 bikes behave like the VirtuFit Etappe device without requiring manual setting changes.Description
X100-asfitplusbikein the central discovery logic by adding theX100-prefix check tobluetooth::deviceDiscovered(src/devices/bluetooth.cpp).virtufitEtappetofitplusbike(src/devices/fitplusbike/fitplusbike.h).virtufitEtappe = truewhen the device is discovered and OR-ing that flag with the existingvirtufit_etappeQSettings checks acrossfitplusbikecode paths (src/devices/fitplusbike/fitplusbike.cpp).X100-prefix (tst/Devices/devicetestdataindex.cpp) and register a device index value (tst/Devices/deviceindex.h/tst/Devices/deviceindex.cpp).Testing
git diff --checkto validate the patch formatting and it passed.X100-andvirtufit_etappeand found the expected edits insrc/devices/bluetooth.cppandsrc/devices/fitplusbike/fitplusbike.cpprespectively.Add X100 VirtuFit Etappe bike detection) successfully; no CI tests were executed in this environment.qmake -vto run the Qt build/test suite butqmakeis not available in the environment so the full test suite could not be run.Codex Task