Fix wrong conversion for Kind in SARIF report (#642)

pascalberger · web-flow · commit f030dcc6602f · 2024-06-02T16:43:32.000+02:00
diff --git a/src/Cake.Issues.Reporting.Sarif/IIssueExtensions.cs b/src/Cake.Issues.Reporting.Sarif/IIssueExtensions.cs
@@ -20,8 +20,10 @@ public static ResultKind Kind(this IIssue issue)
         return issue.Priority.HasValue
             ? issue.Priority switch
             {
-                (int)IssuePriority.Suggestion or (int)IssuePriority.Hint => ResultKind.Informational,
-                (int)IssuePriority.Warning or (int)IssuePriority.Error => ResultKind.Fail,
+                (int)IssuePriority.Suggestion or
+                (int)IssuePriority.Hint or
+                (int)IssuePriority.Warning or
+                (int)IssuePriority.Error => ResultKind.Fail,
                 _ => ResultKind.NotApplicable,
             }
             : ResultKind.None;

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,10 @@ public static ResultKind Kind(this IIssue issue)`
`20`	`20`	`return issue.Priority.HasValue`
`21`	`21`	`? issue.Priority switch`
`22`	`22`	`{`
`23`		`- (int)IssuePriority.Suggestion or (int)IssuePriority.Hint => ResultKind.Informational,`
`24`		`- (int)IssuePriority.Warning or (int)IssuePriority.Error => ResultKind.Fail,`
	`23`	`+ (int)IssuePriority.Suggestion or`
	`24`	`+ (int)IssuePriority.Hint or`
	`25`	`+ (int)IssuePriority.Warning or`
	`26`	`+ (int)IssuePriority.Error => ResultKind.Fail,`
`25`	`27`	`_ => ResultKind.NotApplicable,`
`26`	`28`	`}`
`27`	`29`	`: ResultKind.None;`