refactor(tests): introduce fixtures for agency card flows

Author: lalver1

tests/playwright/qa/__init__.py

@@ -1,6 +1,55 @@
+from dataclasses import dataclass
 import pytest
 
 
+@dataclass
+class AgencyFlow:
+    agency: str
+    flow: str
+
+
+@dataclass
+class AgencyCardCredentials:
+    sub: str
+    name: str
+
+
+@dataclass
+class PaymentCard:
+    cardholder_name: str
+    card_number: str
+    expiration: str
+    security_code: str
+
+
 @pytest.fixture
 def browser_context_args():
     return dict(user_agent="cal-itp/benefits-smoke-test")
+
+
+@pytest.fixture
+def agency_card_flows():
+    return [
+        (
+            AgencyFlow(agency="California State Transit", flow="Agency Cardholder"),
+            AgencyCardCredentials(sub="71162", name="Box"),
+        ),
+        (
+            AgencyFlow(agency="Monterey-Salinas Transit", flow="Courtesy Card"),
+            AgencyCardCredentials(sub="71162", name="Box"),
+        ),
+        (
+            AgencyFlow(agency="Santa Barbara MTD", flow="Reduced Fare Mobility ID"),
+            AgencyCardCredentials(sub="1234", name="Barbara"),
+        ),
+    ]
+
+
+@pytest.fixture
+def valid_payment_card():
+    return PaymentCard(
+        cardholder_name="Test User",
+        card_number="4111 1111 1111 1111",
+        expiration="12/34",
+        security_code="123",
+    )

tests/playwright/qa/conftest.py

@@ -6,6 +6,8 @@
 
 from playwright.sync_api import Page
 
+from .conftest import PaymentCard
+
 
 class Index:
     def __init__(self, page: Page):
@@ -122,7 +124,7 @@ class EnrollmentIndex:
     def __init__(self, page: Page):
         self.page = page
 
-    def enroll(self, cardholder_name, card_number, expiration, security_code):
+    def enroll(self, payment_card: PaymentCard):
         page = self.page
 
         with page.expect_popup() as popup_info:
@@ -133,17 +135,17 @@ def enroll(self, cardholder_name, card_number, expiration, security_code):
 
         popup.get_by_text("Cardholder name").click()
 
-        popup.get_by_label("Cardholder name").fill(cardholder_name)
+        popup.get_by_label("Cardholder name").fill(payment_card.cardholder_name)
         popup.keyboard.press("Tab")
 
-        popup.get_by_label("Card number").fill(card_number)
+        popup.get_by_label("Card number").fill(payment_card.card_number)
         popup.keyboard.press("Tab")
 
-        popup.get_by_label("mm/yy").fill(expiration)
+        popup.get_by_label("mm/yy").fill(payment_card.expiration)
         popup.keyboard.press("Tab")
 
         popup.get_by_text("Security code", exact=True).click()
-        popup.get_by_label("Security code").fill(security_code)
+        popup.get_by_label("Security code").fill(payment_card.security_code)
 
         # trigger form validation - not sure why their form behaves this way
         popup.keyboard.press("Shift+Tab")

tests/playwright/qa/models.py

@@ -1,22 +1,25 @@
 from playwright.sync_api import BrowserContext, expect
 
-from models import Index
+from .models import Index
 
 
-def test_agency_card_flow(context: BrowserContext, base_url):
-    page = context.new_page()
+def test_agency_card_flow(context: BrowserContext, base_url, agency_card_flows, valid_payment_card):
+    for agency_flow, cred in agency_card_flows:
+        print(agency_flow)
 
-    page.goto(base_url)
+        page = context.new_page()
 
-    index = Index(page)
-    eligibility_index = index.select_agency("California State Transit")
-    eligibility_start = eligibility_index.select_flow("Agency Cardholder")
-    eligibility_confirm = eligibility_start.click_continue()
-    enrollment_index = eligibility_confirm.submit_form("71162", "Box")
-    enrollment_index.enroll("Test User", "4111 1111 1111 1111", "12/34", "123")
+        page.goto(base_url)
 
-    # enrollment can take a bit
-    page.wait_for_timeout(10000)
+        index = Index(page)
+        eligibility_index = index.select_agency(agency_flow.agency)
+        eligibility_start = eligibility_index.select_flow(agency_flow.flow)
+        eligibility_confirm = eligibility_start.click_continue()
+        enrollment_index = eligibility_confirm.submit_form(cred.sub, cred.name)
+        enrollment_index.enroll(valid_payment_card)
 
-    success_message = page.get_by_text("You can now use your contactless card to tap to ride with a reduced fare!")
-    expect(success_message).to_be_visible()
+        # enrollment can take a bit
+        page.wait_for_timeout(15000)
+
+        success_message = page.get_by_text("You can now use your contactless card to tap to ride with a reduced fare!")
+        expect(success_message).to_be_visible()

tests/playwright/qa/test_agency_flow.py

@@ -3,7 +3,7 @@
 from playwright.sync_api import BrowserContext, expect
 import pyotp
 
-from models import Index
+from .models import Index
 
 
 def test_older_adult_flow(context: BrowserContext, base_url):

tests/playwright/qa/test_login_gov_flow.py

@@ -1,7 +1,7 @@
 import os
 from playwright.sync_api import BrowserContext, expect
 
-from models import Index
+from .models import Index
 
 
 def test_medicare_cardholder_flow(context: BrowserContext, base_url):