Research Task - Monthly NTD, refactor code

[csuyat-dot]

Research Task

Substantial updates to the Monthly NTD ridership report necessitate a review and possible refactor of the report's code. Since the initial iterations of the report, improvements have been made to; ingesting data from the warehouse instead of the FTA excel files, ingesting rtpa data from the warehouse instead of a curated crosswalk.

Now is a good time to deprecate or entirely remove old functions, and general code clean up.
ex. Are update_vars or ntd_dates modules still needed? Can we consolidate functions from the other products in the same directory

• Relevant PR (if applicable):

• Question or Goal: overarching goal of this issue

• Data Required:

  • Currently have:
  • Need:

• Research Required:

• Metrics: what specific calculations are you looking to find?

• Expected Outputs / Findings: cleaner and more organized code.

[csuyat-dot]

consolidate and move the common functions to the top utils files so it can be used with the other products.

• deploy_portfolio_yaml
• remove_local_outputs
• save_rtpa_outputs
• sum_by_group
• add_change_columns
• get_percent change

[csuyat-dot]

have a single Makeffile at /ntd with different sections for each report to consolidate all the other Makefiles?