Merge pull request #334 from calband/issues/thumbnail_jumps

Issue #333: Field thumbnail seems to Pop

Author: rmpowell77

CMakeLists.txt

@@ -114,7 +114,7 @@ else ()
 target_compile_options (calchart_core PRIVATE -Werror -Wall -Wextra)
 endif ()
 
-set_target_properties (calchart_core PROPERTIES CXX_STANDARD 17)
+set_target_properties (calchart_core PROPERTIES CXX_STANDARD 20)
 
 target_include_directories (
   calchart_core

RELEASE_INSTRUCTIONS.txt

@@ -82,7 +82,9 @@ You'll need to be logged in as Administrator to modify the files.
 
 10. Repeat for Install-CalChart-$CCVER.exe.  Click on zip and edit the file details to signify its platform is Windows and set the release_notes for the file.
 
-11. Update https://github.com/calband/calchart/releases
+11. Update https://github.com/calband/calchart/releases with Readme version updates.
 
-12. Have a cookie.
+12. Update https://github.com/calband/calchart/milestone by closing the shipped milestone and starting the next one.
+
+13. Have a cookie.
 

src/FieldThumbnailBrowser.cpp

@@ -227,6 +227,10 @@ void FieldThumbnailBrowser::HandleMouseDown(wxMouseEvent& event)
 
 void FieldThumbnailBrowser::HandleSizeEvent(wxSizeEvent& event)
 {
-    mLayoutHorizontal = float(event.m_size.x) / float(event.m_size.y) > 1;
+    auto mode_size = mView->GetShowFieldSize();
+    auto ratioMode = mode_size.y ? mode_size.x / float(mode_size.y) : 0;
+    auto ratioSize = event.m_size.y ? event.m_size.x / float(event.m_size.y) : 0;
+
+    mLayoutHorizontal = ratioSize > ratioMode;
     OnUpdate();
 }