Skip to content

Commit 86d8b42

Browse files
authored
Issue #517: Cannot open CalChart, says that application is damaged (#577)
Adding codesigning to github actions. Codesigning for mac involves: 1. Creating a signing cert in p12 form (https://help.apple.com/xcode/mac/current/#/dev154b28f09) 2. Uploading the p12 as github secrets (https://docs.github.com/en/actions/use-cases-and-examples/deploying/installing-an-apple-certificate-on-macos-runners-for-xcode-development) 3. Generating the p12 file on the github action server 4. using indygreg/apple-code-sign-action@v1 to sign the app
1 parent c229d52 commit 86d8b42

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

.github/workflows/cmake.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,25 @@ jobs:
8888
# Build your program with the given configuration
8989
run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
9090

91+
# Codesigning for mac involves:
92+
# 1. Creating a signing cert in p12 form (https://help.apple.com/xcode/mac/current/#/dev154b28f09)
93+
# 2. Uploading the p12 as github secrets (https://docs.github.com/en/actions/use-cases-and-examples/deploying/installing-an-apple-certificate-on-macos-runners-for-xcode-development)
94+
# 3. Generating the p12 file on the github action server
95+
# 4. using indygreg/apple-code-sign-action@v1 to sign the app
96+
- name: Gen p12 (macOS)
97+
if: matrix.config.os == 'macos-14'
98+
env:
99+
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
100+
run: echo $MACOS_CERTIFICATE | base64 --decode > ${{github.workspace}}/certificate.p12
101+
102+
- name: Codesign (macOS)
103+
if: matrix.config.os == 'macos-14'
104+
uses: indygreg/apple-code-sign-action@v1
105+
with:
106+
input_path: ${{github.workspace}}/build/src/CalChart.app
107+
p12_file: ${{github.workspace}}/certificate.p12
108+
p12_password: ${{ secrets.MACOS_CERTIFICATE_PASSWORD }}
109+
91110
- name: Run tests
92111
run: ctest --verbose --test-dir ${{github.workspace}}/build
93112

LATEST_RELEASE_NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Bugs addressed in this release:
55
* [#443](../../issues/443) Dark Mode doesn't show status bar on Mac
66
* [#462](../../issues/462) PDF printing of Continuities seems wrong
77
* [#497](../../issues/497) Animate ctor should be explicit
8+
* [#517](../../issues/517) Cannot open CalChart, says that application is damaged
89
* [#518](../../issues/518) Animation looks wrong
910
* [#540](../../issues/540) Current 3.7.1 does not run
1011
* [#542](../../issues/542) crashes when going to last sheet of animation in RAINBOW show

0 commit comments

Comments
 (0)