Improving config #109
Merged
Improving config #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working out so well)
Conflicts: src/calchartapp.h
Getting changes to have a write-queue, currently disabled. You can change the way things draw.
Conflicts: src/animation_view.cpp src/calchartapp.cpp src/calchartapp.h src/confgr.cpp src/draw.cpp src/draw.h src/field_view.cpp src/modes.cpp src/modes.h
Conflicts: src/animation_frame.cpp src/animation_frame.h
…ow the same caching system. Added Ghost sheet to draw preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big changes. This basically restructures the Configuration system.
Originally the config system is globally, but it then has the problem that it cannot be modified for previewing the changes. It is also intertwined with all the code. This change separates the config system from the rendering part of the code, and also has the facilities for having a way of making changes to the config that aren't committed.
As a bonus the config now has ability to preview the changes before you make them on the preference page.