fix: timezone dependent unit test fail when not on utc #15377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
automated-tests
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (06/08/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/08/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Shaik-Sirajuddin
commented
Jun 8, 2024
| const dateFrom = dayjs().month(10).date(1).startOf("day"); | ||
| const dateTo = dayjs().month(10).endOf("month"); | ||
| const dateFrom = dayjs.utc().month(10).date(1).startOf("day"); | ||
| const dateTo = dayjs.utc().month(10).endOf("month"); |
There was a problem hiding this comment.
using dayjs.utc to avoid change of date ( incremented to next day )
while using dayjs.endOf in certain timezones
|
This PR is being marked as stale due to inactivity. |
|
Closing due to staleness. Please reopen if work continues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
TZ=MST yarn test