[CAL-3766] Offer seats events invites everyone regardless their availibility schedule

[olivierlambert]

Issue Summary

When using an event with "offer seats", despite setting a round robin attribution for the event, all the hosts are invited, regardless their own availability.

Steps to Reproduce

1. Create an event with seats
2. Have 2 hosts with their own availability (which are different/without overlap)
3. Book a meeting at an hour where only one host is available
4. Both hosts are invited

Actual Results

• Both hosts are invited to the event despite their availability is incompatible with the booked slot

Expected Results

• Only the available host should be invited, respecting their own availability

Technical details

• Chrome/FF
• Node.js 18
• Cal v4.07

Evidence

Round robin enabled with 2 hosts:

But the invite:

_CAL-3766

[dosubot]

To resolve the issue where both hosts are invited to an event despite differing availabilities, you'll need to adjust the logic in your application that assigns hosts to events, especially when using the "offer seats" option. Here's a focused approach to tackle this:

1. Adjust Round Robin Logic with Availability Checks: Update the round robin assignment logic to include checks against each host's availability before sending out invites. This means integrating availability verification within the handleSeatsEventTypeOnBooking function or similar, ensuring that only hosts available at the event time are considered.

2. Calendar Integration for Accurate Availability: Enhance how your system checks a host's availability by improving calendar integration. This involves making sure that any existing bookings are considered when assigning hosts to new events, preventing double bookings.

3. Debugging and Testing: Implement detailed logging and develop automated tests that simulate various booking scenarios. This will help ensure that your scheduling system behaves as expected, correctly selecting available hosts for events.

4. Rescheduling Logic: Make sure your application handles event rescheduling properly, updating the assigned host based on their current availability and updating the event details in both the system and the host's calendar.

5. Automated Testing for Edge Cases: Develop tests for edge cases, such as overlapping host availabilities or rescheduling, to ensure your system can handle these scenarios gracefully.

6. External Calendar Updates: Ensure that when an event is rescheduled or a host's assignment changes, the event details are correctly updated in any connected external calendars.

7. Fallback Mechanisms for Errors: Implement mechanisms to handle scenarios where no hosts are available or other errors occur, such as notifying an administrator or suggesting alternative booking times to the user.

By refining your scheduling system's logic with these steps, you should be able to ensure that only the host who is available at the time of the booked meeting is invited, aligning with the expected behavior of the "offer seats" option and round robin attribution.

Details

Sources

• Round robin: optimize for equal distribution
• [CAL-471] Calendar conflict is ignored in Round Robin meetings using individual default availability
• packages/features/bookings/lib/handleNewBooking/test/recurring-event.test.ts
• packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
• apps/web/lib/booking.ts
• packages/app-store/googlecalendar/lib/CalendarService.ts
• packages/app-store/googlecalendar/tests/google-calendar.e2e.ts
• packages/features/bookings/lib/handleNewBooking.ts
• packages/lib/errorCodes.ts
• packages/features/bookings/lib/handleNewBooking/test/team-bookings/collective-scheduling.test.ts
• apps/web/components/eventtype/EventAdvancedTab.tsx
• packages/features/bookings/lib/handleSeats/create/createNewSeat.ts
• packages/features/bookings/lib/handleSeats/reschedule/rescheduleSeatedBooking.ts
• packages/features/bookings/components/SeatsAvailabilityText.tsx
• packages/features/bookings/lib/handleSeats/reschedule/owner/combineTwoSeatedBookings.ts
• apps/web/components/eventtype/EventTeamTab.tsx
• packages/platform/atoms/hooks/useSlots.ts
• packages/features/bookings/lib/handleSeats/handleSeats.ts
• packages/features/bookings/components/AvailableTimes.tsx

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

[rk9595]

Can I take this issue?

[olivierlambert]

Hello there!

Anything I can do to make the PR merged?