fix: improve redirect parameter handling for success page #20764
Conversation
|
@guptadeepak8 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
automated-tests
![mrge-io[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/18/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (04/18/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
@guptadeepak8 visual demo is important here - can you add , making it draft until then.
|
previous:- changes:- Screen.Recording.2025-04-18.162056.mp4 |
| @@ -185,7 +194,7 @@ export const useBookingSuccessRedirect = () => { | |||
| ...query, | |||
| ...bookingExtraParams, | |||
| }, | |||
| searchParams: new URLSearchParams(searchParams.toString()), | |||
| searchParams: filterEmbedParameter(searchParams, isEmbed), | |||
There was a problem hiding this comment.
Instead of making it embed specific we should handle removing the param in getBookingRedirectExtraParams and unit test that function as that function has the responidbility of building what params to send
There was a problem hiding this comment.
@guptadeepak8 Thanks for the PR !! I have left a suggestion to implement it in a better way
Making it draft until then |
Summary by mrge
Improved redirect handling by removing the unused "embed" parameter before forwarding users to the success page.
What does this PR do?
Improved query parameter handling by removing the unused embed param before forwarding to success page
Mandatory Tasks (DO NOT REMOVE)