chore: address review comment style

Author: Maheshkumarjena

packages/app-store/office365calendar/lib/CalendarService.ts

@@ -320,12 +320,8 @@ class Office365CalendarService implements Calendar {
   }
 
   /**
-   * Updates an Office365 calendar event and handles seated attendee-only updates.
-   *
-   * @param uid - Office365 event identifier to update.
-   * @param event - Calendar event data to send to Microsoft Graph.
-   * @param externalCalendarId - Optional Office365 calendar identifier containing the event.
-   * @returns Updated Office365 event details.
+   * Seated bookings split event-detail and attendee patches because Exchange can turn combined
+   * attendee-list mutations into organizer-level updates for everyone on the event.
    */
   async updateEvent(
     uid: string,
@@ -348,7 +344,6 @@ class Office365CalendarService implements Calendar {
         rescheduledEvent = await handleErrorsJson<Event>(response);
       }
 
-      // Build the full translated event object
       const translatedEvent = this.translateEvent(event, rescheduledEvent);
 
       let response: Response;
@@ -386,26 +381,17 @@ class Office365CalendarService implements Calendar {
             lastError = err instanceof Error ? err : new Error(String(err));
 
             if (attempt < MAX_RETRIES) {
-              // Exponential backoff before next attempt
+              // Exchange can lag after the first seated-booking patch, so retry attendee sync briefly.
               const backoff = BACKOFF_MS * 2 ** (attempt - 1);
               this.log.warn(
                 `PATCH_ATTENDEES attempt ${attempt}/${MAX_RETRIES} failed for event uid=${uid}, retrying in ${backoff}ms`,
                 { err }
               );
-              await new Promise(
-                /**
-                 * Resolves the retry delay after the computed backoff.
-                 *
-                 * @param resolve - Promise resolver called when the delay completes.
-                 * @returns Timeout handle created for the retry delay.
-                 */
-                (resolve) => setTimeout(resolve, backoff)
-              );
+              await new Promise((resolve) => setTimeout(resolve, backoff));
             }
           }
         }
 
-        // Retry failure handling for PATCH 2
         if (lastError) {
           let httpStatus: number | undefined;
           let httpBody: unknown;
@@ -415,14 +401,7 @@ class Office365CalendarService implements Calendar {
             try {
               httpBody = await patch2Response.json();
             } catch {
-              httpBody = await patch2Response.text().catch(
-                /**
-                 * Provides a fallback body when the Graph response text cannot be read.
-                 *
-                 * @returns Fallback response body message.
-                 */
-                () => "unable to read response body"
-              );
+              httpBody = await patch2Response.text().catch(() => "unable to read response body");
             }
           }
 
@@ -445,7 +424,6 @@ class Office365CalendarService implements Calendar {
           );
         }
 
-        // PATCH 2 succeeded — use its response for the return value below
         response = patch2Response!;
       } else {
         response = await this.fetcher(eventEndpoint, {
@@ -470,12 +448,8 @@ class Office365CalendarService implements Calendar {
   }
 
   /**
-   * Deletes an Office365 event from the same calendar that stored its reference.
-   *
-   * @param uid - Office365 event identifier to delete.
-   * @param _event - Calendar event associated with the deletion.
-   * @param externalCalendarId - Optional Office365 calendar identifier containing the event.
-   * @returns A promise that resolves when Microsoft Graph accepts the delete.
+   * Selected Outlook calendars require their own Graph delete path; the default-calendar path
+   * cannot remove events created outside the primary calendar.
    */
   async deleteEvent(uid: string, _event: CalendarEvent, externalCalendarId?: string | null): Promise<void> {
     try {
@@ -493,12 +467,7 @@ class Office365CalendarService implements Calendar {
   }
 
   /**
-   * Builds the Graph event URL for default or explicitly selected calendars.
-   *
-   * @param endpoint - Graph user endpoint for the credential.
-   * @param uid - Office365 event identifier.
-   * @param externalCalendarId - Optional selected calendar identifier.
-   * @returns Microsoft Graph event endpoint for the target calendar.
+   * Graph separates default-calendar events from explicitly selected calendar events at the URL level.
    */
   private getEventEndpoint(endpoint: string, uid: string, externalCalendarId?: string | null) {
     return externalCalendarId

packages/emails/templates/attendee-scheduled-email.ts

@@ -15,12 +15,8 @@ export default class AttendeeScheduledEmail extends BaseEmail {
   t: TFunction;
 
   /**
-   * Builds an attendee scheduled email with seated attendee visibility applied.
-   *
-   * @param calEvent - Calendar event used to render the scheduled email.
-   * @param attendee - Recipient attendee for the scheduled email.
-   * @param showAttendees - Optional override for displaying other seated attendees.
-   * @returns A configured attendee scheduled email instance.
+   * Seated booking confirmations render from the recipient's perspective so later attendees do
+   * not inherit the first attendee's name in Outlook-generated invite content.
    */
   constructor(calEvent: CalendarEvent, attendee: Person, showAttendees?: boolean | undefined) {
     super();
@@ -38,15 +34,7 @@ export default class AttendeeScheduledEmail extends BaseEmail {
       if (shouldShowAttendees) {
         attendees = [
           attendee,
-          ...calEvent.attendees.filter(
-            /**
-             * Keeps the current attendee first by removing duplicate attendee entries.
-             *
-             * @param eventAttendee - Attendee from the original calendar event.
-             * @returns Whether the attendee should remain after the recipient.
-             */
-            (eventAttendee) => eventAttendee.email !== attendee.email
-          ),
+          ...calEvent.attendees.filter((eventAttendee) => eventAttendee.email !== attendee.email),
         ];
       }
 

packages/features/bookings/lib/handleSeats/cancel/cancelAttendeeSeat.ts

@@ -23,10 +23,8 @@ import type { BookingToDelete } from "../../handleCancelBooking";
 import { getSeatCalendarReferences, OFFICE365_CALENDAR_TYPE } from "../lib/seatCalendarReferences";
 
 /**
- * Creates a stable key for comparing Office365 references across seat and booking storage.
- *
- * @param reference - Office365 calendar reference to compare.
- * @returns Stable key for identifying the same Office365 event reference.
+ * Booking-level fallback can contain multiple Office365 refs, so compare every provider identity
+ * field before deciding which event was already handled.
  */
 const getOffice365ReferenceKey = (
   reference: Pick<
@@ -43,12 +41,8 @@ const getOffice365ReferenceKey = (
   ]);
 
 /**
- * Cancels a single attendee seat and updates affected integrations.
- *
- * @param data - Seat cancellation input and booking data.
- * @param dataForWebhooks - Webhook and calendar event data for cancellation side effects.
- * @param eventTypeMetadata - Event type metadata used for cancellation notifications.
- * @returns A promise that resolves after the attendee seat cancellation is processed.
+ * Seat cancellation must preserve the group booking while isolating provider cleanup to the
+ * attendee who is leaving.
  */
 async function cancelAttendeeSeat(
   data: {
@@ -115,6 +109,7 @@ async function cancelAttendeeSeat(
       seatReference.metadata,
       OFFICE365_CALENDAR_TYPE
     );
+    // Pre-fix seated bookings stored Office365 refs on the booking, so keep that fallback for cleanup.
     const bookingLevelOffice365References = bookingToDelete.references.filter(
       (reference) => reference.type === OFFICE365_CALENDAR_TYPE
     );
@@ -149,6 +144,7 @@ async function cancelAttendeeSeat(
         return true;
       }
 
+      // Per-seat Office365 events are deleted directly; shared updates would notify attendees who are staying.
       if (seatOffice365CalendarReferences.length > 0) {
         return false;
       }
@@ -180,15 +176,8 @@ async function cancelAttendeeSeat(
             };
           }
 
-          const attendees = evt.attendees.filter(
-            /**
-             * Removes the canceled attendee from the shared event attendee list.
-             *
-             * @param evtAttendee - Calendar event attendee to inspect.
-             * @returns Whether the attendee should remain on the shared event.
-             */
-            (evtAttendee) => attendee.email !== evtAttendee.email
-          );
+          // Shared non-Office365 integrations still update the attendee list, so keep the leaving seat out.
+          const attendees = evt.attendees.filter((evtAttendee) => attendee.email !== evtAttendee.email);
           const updatedEvt = {
             ...evt,
             attendees,

packages/features/bookings/lib/service/RegularBookingService.ts

@@ -488,13 +488,8 @@ async function validateRescheduleRestrictions({
 }
 
 /**
- * Creates or reschedules a regular booking and records integration references.
- *
- * @param this - Regular booking service instance bound to the handler.
- * @param input - Booking request data and platform context.
- * @param deps - Service dependencies used by the booking flow.
- * @param bookingDataSchemaGetter - Optional schema factory for booking data validation.
- * @returns Booking response containing created references and seat metadata.
+ * Calendar references are recorded here because cancellation and reschedule flows need provider
+ * event IDs after the booking transaction completes.
  */
 async function handler(
   this: RegularBookingService,
@@ -2454,13 +2449,8 @@ async function handler(
 
   if (!booking) throw new HttpError({ statusCode: 400, message: "Booking failed" });
 
+  // Single-seat cancellation deletes by provider UID, so only concrete Office365 events belong in seat metadata.
   const office365SeatReferences = referencesToCreate.filter(
-    /**
-     * Keeps valid Office365 references created for a seated booking seat.
-     *
-     * @param reference - Calendar reference created during booking.
-     * @returns Whether the reference should be stored on the booking seat.
-     */
     (reference) => reference.type === OFFICE365_CALENDAR_TYPE && reference.uid
   );
   const shouldPersistOffice365SeatReferences =
@@ -2484,6 +2474,7 @@ async function handler(
       });
 
       if (shouldPersistOffice365SeatReferences && evt.attendeeSeatId) {
+        // Seat metadata must persist with booking references or Outlook cleanup loses the per-attendee event.
         await deps.prismaClient.$transaction([
           bookingUpdate,
           deps.prismaClient.bookingSeat.update({