Skip to content

Commit 805b7ed

Browse files
committed
fix: address Proton Calendar review comments
1 parent 577004b commit 805b7ed

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

apps/web/components/apps/protoncalendar/Setup.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default function ProtonCalendarSetup() {
2727
{/* eslint-disable @next/next/no-img-element */}
2828
<img
2929
src="/api/app-store/protoncalendar/icon.svg"
30-
alt="Proton Calendar"
30+
alt={t("proton_calendar")}
3131
className="h-12 w-12 max-w-2xl"
3232
/>
3333
</div>
@@ -73,7 +73,7 @@ export default function ProtonCalendarSetup() {
7373
const newVal = e.target.value as string;
7474
setUrls((urls) => urls.map((x, ii) => (ii === i ? newVal : x)));
7575
}}
76-
placeholder="webcal://calendar.proton.me/api/calendar/v1/url/..."
76+
placeholder={t("proton_calendar_url_placeholder")}
7777
/>
7878
{i !== 0 ? (
7979
<button

packages/app-store/protoncalendar/api/add.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,9 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse)
6868
data,
6969
});
7070
} catch (error) {
71-
logger.error("Could not add Proton Calendar feeds", error);
71+
logger.error("Could not add Proton Calendar feeds", {
72+
message: error instanceof Error ? error.message : "Unknown error",
73+
});
7274
return res.status(500).json({ message: "Could not add Proton Calendar feeds" });
7375
}
7476

packages/i18n/locales/en/common.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -440,6 +440,8 @@
440440
"connect_caldav": "Connect to CalDav (Beta)",
441441
"connect_ics_feed": "Connect to an ICS Feed",
442442
"connect_proton_calendar": "Connect to Proton Calendar",
443+
"proton_calendar": "Proton Calendar",
444+
"proton_calendar_url_placeholder": "webcal://calendar.proton.me/api/calendar/v1/url/...",
443445
"connect": "Connect",
444446
"try_for_free": "Try it for free",
445447
"create_booking_link_with_calcom": "Create your own booking link with {{appName}}",

0 commit comments

Comments
 (0)