refactor(move): move managed device allocation into its own workspace package (#2316) (#2321)

* refactor(move): move managed device allocation into its own workspace package (#2316)

* chore(gates): unrank the managed-allocation zone, declare its durable-json seam, and ignore its unconsumed root dependency (#2316)

Author: thymikee

.fallowrc.json

@@ -56,6 +56,9 @@
     // @agent-device/provider-limrun owns the source import, while the published
     // root build externalizes @limrun/api and retains runtime imports in packed chunks.
     "@limrun/api",
+    // @agent-device/managed-allocation has no root consumer yet: the managed runtime binding
+    // (ADR 0021 §3) is its first, and it lands after the package's move out of src/daemon.
+    "@agent-device/managed-allocation",
     // Oxlint resolves the shared config's JS plugins dynamically from their package names.
     "@nkzw/eslint-plugin",
     "eslint-plugin-no-only-tests",

package.json

@@ -167,7 +167,7 @@
     "check:unit": "pnpm test:unit && pnpm check:tmpdir-leaks && pnpm test:smoke",
     "check": "pnpm check:tooling && pnpm check:fallow && pnpm check:unit",
     "prepack": "pnpm check:mcp-metadata && pnpm package:npm",
-    "typecheck": "tsc -b packages/xml packages/kernel packages/contracts packages/host-kit packages/capture-kit packages/provision-kit packages/platform-apple packages/platform-android packages/platform-harmonyos packages/platform-vega packages/platform-linux packages/platform-web packages/ad-script packages/selectors packages/ad-replay packages/maestro packages/replay-test packages/provider-webdriver packages/provider-limrun && tsc -p tsconfig.json && tsc -p examples/sdk/tsconfig.json",
+    "typecheck": "tsc -b packages/xml packages/kernel packages/contracts packages/host-kit packages/capture-kit packages/managed-allocation packages/provision-kit packages/platform-apple packages/platform-android packages/platform-harmonyos packages/platform-vega packages/platform-linux packages/platform-web packages/ad-script packages/selectors packages/ad-replay packages/maestro packages/replay-test packages/provider-webdriver packages/provider-limrun && tsc -p tsconfig.json && tsc -p examples/sdk/tsconfig.json",
     "test-app:install": "pnpm install --dir examples/test-app",
     "test-app:start": "pnpm --dir examples/test-app start",
     "test-app:ios": "pnpm --dir examples/test-app ios",
@@ -280,6 +280,7 @@
     "@agent-device/contracts": "workspace:*",
     "@agent-device/host-kit": "workspace:*",
     "@agent-device/kernel": "workspace:*",
+    "@agent-device/managed-allocation": "workspace:*",
     "@agent-device/maestro": "workspace:*",
     "@agent-device/platform-android": "workspace:*",
     "@agent-device/platform-apple": "workspace:*",

packages/capture-kit/package.json

@@ -14,6 +14,10 @@
       "types": "./src/index.ts",
       "default": "./src/index.ts"
     },
+    "./durable-json": {
+      "types": "./src/durable-json.ts",
+      "default": "./src/durable-json.ts"
+    },
     "./ios-snapshot-acquisition": {
       "types": "./src/ios-snapshot-acquisition.ts",
       "default": "./src/ios-snapshot-acquisition.ts"

packages/managed-allocation/package.json

@@ -0,0 +1,47 @@
+{
+  "name": "@agent-device/managed-allocation",
+  "version": "0.0.0",
+  "private": true,
+  "type": "module",
+  "description": "Private managed-device allocation-operation mechanics composed by the daemon: durable allocation-operation store, recovery journal, decision policy, and record codec for the Simlock-backed lease handoff (ADR 0021).",
+  "dependencies": {
+    "@agent-device/capture-kit": "workspace:*",
+    "@agent-device/contracts": "workspace:*",
+    "@agent-device/host-kit": "workspace:*",
+    "@agent-device/kernel": "workspace:*"
+  },
+  "exports": {
+    "./decision": {
+      "types": "./src/decision.ts",
+      "default": "./src/decision.ts"
+    },
+    "./fence": {
+      "types": "./src/fence.ts",
+      "default": "./src/fence.ts"
+    },
+    "./journal": {
+      "types": "./src/journal.ts",
+      "default": "./src/journal.ts"
+    },
+    "./record": {
+      "types": "./src/record.ts",
+      "default": "./src/record.ts"
+    },
+    "./schema": {
+      "types": "./src/schema.ts",
+      "default": "./src/schema.ts"
+    },
+    "./status": {
+      "types": "./src/status.ts",
+      "default": "./src/status.ts"
+    },
+    "./store": {
+      "types": "./src/store.ts",
+      "default": "./src/store.ts"
+    },
+    "./transitions": {
+      "types": "./src/transitions.ts",
+      "default": "./src/transitions.ts"
+    }
+  }
+}

…ce-allocation/__tests__/decision.test.ts …llocation/src/__tests__/decision.test.tssrc/daemon/managed-device-allocation/__tests__/decision.test.ts renamed to packages/managed-allocation/src/__tests__/decision.test.ts src/daemon/managed-device-allocation/__tests__/decision.test.ts renamed to packages/managed-allocation/src/__tests__/decision.test.ts

@@ -1,6 +1,6 @@
 import assert from 'node:assert/strict';
 import { test } from 'vitest';
-import { newAllocationOperation } from '../record-factory.ts';
+import { newAllocationOperation } from '../record.ts';
 import { applyAllocationTransition } from '../transitions.ts';
 import { decideAllocationAction } from '../decision.ts';
 import { ALLOCATION_LEASE, ALLOCATION_REQUEST } from './fixtures.ts';

…-device-allocation/__tests__/fixtures.ts …ged-allocation/src/__tests__/fixtures.tssrc/daemon/managed-device-allocation/__tests__/fixtures.ts renamed to packages/managed-allocation/src/__tests__/fixtures.ts src/daemon/managed-device-allocation/__tests__/fixtures.ts renamed to packages/managed-allocation/src/__tests__/fixtures.ts

@@ -7,9 +7,9 @@ import type {
   ManagedDeviceAllocatorPort,
   SupersedeLeaseRequestInput,
 } from '@agent-device/contracts/managed-device-allocation';
-import type { ScriptedAllocatorMethod } from '../../../__tests__/test-utils/managed-device-allocator.fixtures.ts';
-import { createScriptedManagedDeviceAllocator } from '../../../__tests__/test-utils/managed-device-allocator.fixtures.ts';
-import { mkdtempForTestSync } from '../../../__tests__/test-utils/tmp-dir.ts';
+import type { ScriptedAllocatorMethod } from './test-utils/managed-device-allocator.fixtures.ts';
+import { createScriptedManagedDeviceAllocator } from './test-utils/managed-device-allocator.fixtures.ts';
+import { mkdtempForTestSync } from './test-utils/tmp-dir.ts';
 import { createAllocationOperationJournal, type AllocationBindingHooks } from '../journal.ts';
 import { createAllocationOperationStore, type AllocationOperationStore } from '../store.ts';
 import {

…ice-allocation/__tests__/journal.test.ts …allocation/src/__tests__/journal.test.tssrc/daemon/managed-device-allocation/__tests__/journal.test.ts renamed to packages/managed-allocation/src/__tests__/journal.test.ts src/daemon/managed-device-allocation/__tests__/journal.test.ts renamed to packages/managed-allocation/src/__tests__/journal.test.ts

@@ -3,11 +3,15 @@ import { test } from 'vitest';
 import type { LeaseRequestStatus } from '@agent-device/contracts/managed-device-allocation';
 import { managedBindingFence } from '@agent-device/contracts/platform-runtime';
 import { AppError } from '@agent-device/kernel/errors';
-import { ALLOCATION_OPERATION_SCHEMA_VERSION, bindingFenceFor } from '../record.ts';
-import { newAllocationOperation } from '../record-factory.ts';
+import {
+  ALLOCATION_OPERATION_SCHEMA_VERSION,
+  bindingFenceFor,
+  decodeAllocationOperationRecord,
+  newAllocationOperation,
+  type AllocationOperationRecord,
+  type AllocationTransition,
+} from '../record.ts';
 import { applyAllocationTransition } from '../transitions.ts';
-import type { AllocationOperationRecord, AllocationTransition } from '../record.ts';
-import { decodeAllocationOperationRecord } from '../record-codec.ts';
 import {
   ALLOCATION_GRANTED_STATUS,
   ALLOCATION_LEASE,

…vice-allocation/__tests__/record.test.ts …-allocation/src/__tests__/record.test.tssrc/daemon/managed-device-allocation/__tests__/record.test.ts renamed to packages/managed-allocation/src/__tests__/record.test.ts src/daemon/managed-device-allocation/__tests__/record.test.ts renamed to packages/managed-allocation/src/__tests__/record.test.ts

@@ -4,9 +4,8 @@ import path from 'node:path';
 import { test, vi } from 'vitest';
 import { acquireProcessLock } from '@agent-device/host-kit/file';
 import { readCurrentOwnerIdentity } from '@agent-device/host-kit/process';
-import { mkdtempForTestSync } from '../../../__tests__/test-utils/tmp-dir.ts';
-import { newAllocationOperation } from '../record-factory.ts';
-import type { AllocationOperationRecord } from '../record.ts';
+import { mkdtempForTestSync } from './test-utils/tmp-dir.ts';
+import { newAllocationOperation, type AllocationOperationRecord } from '../record.ts';
 import { createAllocationOperationStore, type AllocationOperationStore } from '../store.ts';
 import { ALLOCATION_LEASE, ALLOCATION_REQUEST } from './fixtures.ts';
 

…evice-allocation/__tests__/store.test.ts …d-allocation/src/__tests__/store.test.tssrc/daemon/managed-device-allocation/__tests__/store.test.ts renamed to packages/managed-allocation/src/__tests__/store.test.ts src/daemon/managed-device-allocation/__tests__/store.test.ts renamed to packages/managed-allocation/src/__tests__/store.test.ts

@@ -0,0 +1,54 @@
+import type { ManagedDeviceAllocatorPort } from '@agent-device/contracts/managed-device-allocation';
+
+export type ScriptedAllocatorMethod = keyof Omit<ManagedDeviceAllocatorPort, 'instanceId'>;
+
+export type ScriptedAllocatorCall = Readonly<{
+  method: ScriptedAllocatorMethod;
+  input: unknown;
+}>;
+
+export type ScriptedManagedDeviceAllocator = ManagedDeviceAllocatorPort &
+  Readonly<{ calls: ScriptedAllocatorCall[] }>;
+
+/**
+ * The only implementation of the allocator port in the foundations: it replays one scripted step
+ * per call, in the order the script lists them for that method, and refuses a call the script did
+ * not anticipate. No transport, no timers, and no lifecycle rules of its own — a test that wants
+ * an allocator behavior states it as a step.
+ */
+export function createScriptedManagedDeviceAllocator(
+  options: {
+    instanceId?: string;
+    script?: Partial<Record<ScriptedAllocatorMethod, readonly unknown[]>>;
+  } = {},
+): ScriptedManagedDeviceAllocator {
+  const calls: ScriptedAllocatorCall[] = [];
+  const remaining = new Map<ScriptedAllocatorMethod, unknown[]>(
+    Object.entries(options.script ?? {}).map(([method, steps]) => [
+      method as ScriptedAllocatorMethod,
+      [...(steps ?? [])],
+    ]),
+  );
+  const next = async <Result>(method: ScriptedAllocatorMethod, input: unknown): Promise<Result> => {
+    calls.push(Object.freeze({ method, input }));
+    const steps = remaining.get(method) ?? [];
+    if (steps.length === 0) throw new Error(`Unscripted allocator call: ${method}`);
+    const step = steps.shift();
+    if (step instanceof Error) throw step;
+    return step as Result;
+  };
+  return Object.freeze({
+    instanceId: options.instanceId ?? 'scripted-allocator',
+    calls,
+    requestLease: async (input) => await next('requestLease', input),
+    getLeaseRequestStatus: async (request) => await next('getLeaseRequestStatus', request),
+    supersedeLeaseRequest: async (input) => await next('supersedeLeaseRequest', input),
+    cancelLeaseRequest: async (request) => await next('cancelLeaseRequest', request),
+    renewLease: async (input) => await next('renewLease', input),
+    releaseLease: async (input) => await next('releaseLease', input),
+    confirmLeaseActivation: async (proof) => await next('confirmLeaseActivation', proof),
+    getManagedIdentityStatus: async (identity) => await next('getManagedIdentityStatus', identity),
+    acknowledgeManagedIdentityRemoval: async (identity) =>
+      await next('acknowledgeManagedIdentityRemoval', identity),
+  });
+}