Skip to content

Commit f5fa3a5

Browse files
committed
refactor(android): read accessibility increments directly from ReadableArray
setAccessibilityIncrements was going ReadableArray -> ArrayList<Object> via toArrayList() and then copying again into ArrayList<String> with an unchecked (String) cast. Read strings directly via getString(i) into a presized list. Drops the redundant intermediate allocation and the unsafe cast.
1 parent 2696bb8 commit f5fa3a5

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ public static void setAccessibilityUnits(ReactSlider view, String accessibilityU
124124
}
125125

126126
public static void setAccessibilityIncrements(ReactSlider view, ReadableArray accessibilityIncrements) {
127-
List objectList = accessibilityIncrements.toArrayList();
128-
List<String> stringList = new ArrayList<>();
129-
for(Object item: objectList) {
130-
stringList.add((String)item);
127+
int size = accessibilityIncrements.size();
128+
List<String> stringList = new ArrayList<>(size);
129+
for (int i = 0; i < size; i++) {
130+
stringList.add(accessibilityIncrements.getString(i));
131131
}
132132
view.setAccessibilityIncrements(stringList);
133133
}

0 commit comments

Comments
 (0)