Skip to content

Commit 14572c2

Browse files
committed
fix(ci): lint after building packages
1 parent 77273e6 commit 14572c2

File tree

3 files changed

+8
-21
lines changed

3 files changed

+8
-21
lines changed

.github/workflows/ci-cd.yml

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ on:
1313
concurrency: ${{ github.workflow }}-${{ github.ref }}
1414

1515
jobs:
16-
lint:
17-
name: Lint
16+
build-packages-and-lint:
17+
name: Build packages and lint
1818
runs-on: ubuntu-latest
1919
steps:
2020
- name: Checkout
@@ -25,32 +25,19 @@ jobs:
2525
- name: Setup
2626
uses: ./.github/actions/setup
2727

28+
- name: Build packages
29+
run: pnpm run build
30+
2831
- name: Lint files
2932
run: pnpm run lint
3033

3134
- name: Typecheck files
3235
run: pnpm run typecheck
3336

34-
build-packages:
35-
name: Build packages
36-
runs-on: ubuntu-latest
37-
needs: lint
38-
steps:
39-
- name: Checkout
40-
uses: actions/checkout@v4
41-
with:
42-
submodules: 'true'
43-
44-
- name: Setup
45-
uses: ./.github/actions/setup
46-
47-
- name: Build packages
48-
run: pnpm run build
49-
5037
test:
5138
name: Run tests
5239
runs-on: ubuntu-latest
53-
needs: build-packages
40+
needs: build-packages-and-lint
5441
steps:
5542
- name: Checkout
5643
uses: actions/checkout@v4
@@ -66,7 +53,7 @@ jobs:
6653
build-docs:
6754
name: Build docs
6855
runs-on: ubuntu-latest
69-
needs: build-packages
56+
needs: build-packages-and-lint
7057
steps:
7158
- name: Checkout
7259
uses: actions/checkout@v4

examples/rn-app/.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,3 @@ android/config/licenses
7474
/cpp/
7575
/ios/cpp/
7676
/ios/Settings.bundle
77-
/presentation/

packages/core/.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
node_modules/
22
lib/
33
react-native.config.js
4+
third_party/

0 commit comments

Comments
 (0)