Skip to content

Commit 1bc3499

Browse files
authored
fix: broken integration tests (#96)
1 parent b08fa1a commit 1bc3499

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

.github/workflows/test-e2e-android.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
api-level: ${{ matrix.api-level }}
105105
arch: 'x86_64'
106106
target: 'google_apis'
107-
force-avd-creation: ${{ steps.avd-cache.outputs.cache-hit != 'true' }}
107+
force-avd-creation: true
108108
cores: 4
109109
emulator-options: -verbose -no-snapshot-load -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-front none -camera-back none
110110
disable-animations: false

.github/workflows/test-integration-node.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
- 'packages/license-kit/**/*.[tj]sx?'
1010
- 'packages/licenses-api/**/*.[tj]sx?'
1111
- 'examples/node-example/**/*.[tj]sx?'
12+
- 'examples/node-example/package.json'
1213

1314
push:
1415
branches:

examples/node-example/__tests__/report.spec.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@ describe('license-kit report', () => {
7373
it('without transitive deps and without dev deps', async () => {
7474
const json = await runReportCommandForJsonOutput(['--dev-deps-mode', 'none', '--transitive-deps-mode', 'none']);
7575

76-
expect(Object.keys(json).toSorted()).toEqual([...dependencies, ...optionalDependencies].toSorted());
76+
expect(stripVersionSuffixes(Object.keys(json).toSorted())).toEqual(
77+
stripVersionSuffixes([...dependencies, ...optionalDependencies].toSorted()),
78+
);
7779
});
7880

7981
it('without transitive deps and with root-only dev deps', async () => {
@@ -84,8 +86,10 @@ describe('license-kit report', () => {
8486
'none',
8587
]);
8688

87-
expect(Object.keys(json).toSorted()).toEqual(
88-
Array.from(new Set([...dependencies, ...optionalDependencies, ...devDependencies])).toSorted(),
89+
expect(stripVersionSuffixes(Object.keys(json).toSorted())).toEqual(
90+
stripVersionSuffixes(
91+
Array.from(new Set([...dependencies, ...optionalDependencies, ...devDependencies])).toSorted(),
92+
),
8993
);
9094
});
9195

examples/node-example/__utils__/utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ export function getDependencyCorrespondingKey(
1919
dependencyMapping: Record<string, string>,
2020
packageName: string,
2121
): string | undefined {
22-
return dependencyMapping[packageName] ? `${packageName}@${dependencyMapping[packageName]}` : undefined;
22+
return dependencyMapping[packageName]
23+
? `${packageName}@${dependencyMapping[packageName].replace('^', '').replace('~', '')}`
24+
: undefined;
2325
}
2426

2527
/**

0 commit comments

Comments
 (0)