fix(create-app): handle non commented out cliFile (#545)

* fix(create-app): handle non commented out cliFile

* chore: missing line

* chore: sort imports

* chore: add changeset

Author: bacarybruno

.changeset/pink-mails-design.md

@@ -0,0 +1,5 @@
+---
+'create-rock': patch
+---
+
+Updated the cliFile regex and add a warning when the file content cannot be modified.

packages/create-app/src/lib/utils/__tests__/initInExistingProject.test.ts

@@ -0,0 +1,110 @@
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+import { cleanup, getTempDirectory, writeFiles } from '@rock-js/test-helpers';
+import * as tools from '@rock-js/tools';
+import { updateAndroidBuildGradle } from "../initInExistingProject.js";
+
+const directory = getTempDirectory('test_updateAndroidBuildGradle');
+
+afterEach(() => {
+  cleanup(directory);
+});
+
+describe('updateAndroidBuildGradle', () => {
+  const workingCases = [
+    {
+      name: 'cliFile is commented out',
+      content: `
+        react {
+          // cliFile = file("../../node_modules/react-native/cli.js")
+        }
+      `,
+      expected: `
+        react {
+          cliFile = file("../../node_modules/rock/dist/src/bin.js")
+        }
+      `,
+    },
+    {
+      name: 'cliFile is not commented out',
+      content: `
+        reactNativeDir = file("../../node_modules/react-native")
+
+        react {
+          cliFile = file("\${reactNativeDir}/cli.js")
+        }
+      `,
+      expected: `
+        reactNativeDir = file("../../node_modules/react-native")
+
+        react {
+          cliFile = file("../../node_modules/rock/dist/src/bin.js")
+        }
+      `,
+    },
+    {
+      name: 'cliFile is using a variable',
+      content: `
+        reactNativeDir = file("../../node_modules/react-native")
+
+        react {
+          cliFile = file("\${reactNativeDir}/cli.js")
+        }
+      `,
+      expected: `
+        reactNativeDir = file("../../node_modules/react-native")
+
+        react {
+          cliFile = file("../../node_modules/rock/dist/src/bin.js")
+        }
+      `,
+    },
+  ];
+
+  it.each(workingCases)('should update the Android build.gradle file when $name', ({ content, expected }) => {
+    const files = {
+      'android/app/build.gradle': content,
+    };
+    writeFiles(directory, files);
+    updateAndroidBuildGradle(directory, 'android');
+
+    expect(fs.readFileSync(path.join(directory, 'android/app/build.gradle'), 'utf8')).toStrictEqual(expected)
+  });
+
+  it('should not update the Android build.gradle file when cliFile is already set', () => {
+    const content = `
+      react {
+        cliFile = file("../../node_modules/rock/dist/src/bin.js")
+      }
+    `;
+    const files = {
+      'android/app/build.gradle': content,
+    };
+
+    writeFiles(directory, files);
+    updateAndroidBuildGradle(directory, 'android');
+
+    expect(fs.readFileSync(path.join(directory, 'android/app/build.gradle'), 'utf8')).toStrictEqual(content)
+  });
+
+  it('should display a warning when unable to update the Android build.gradle file', () => {
+    const warn = vi.spyOn(tools.logger, 'warn');
+
+    const content = `
+      react {}
+    `;
+
+    const files = {
+      'android/app/build.gradle': content,
+    };
+
+    writeFiles(directory, files);
+    updateAndroidBuildGradle(directory, 'android');
+
+    expect(fs.readFileSync(path.join(directory, 'android/app/build.gradle'), 'utf8')).toStrictEqual(content)
+
+    expect(warn).toHaveBeenCalledWith(
+      expect.stringContaining('Unable to update')
+    )
+  });
+});

packages/create-app/src/lib/utils/initInExistingProject.ts

@@ -166,22 +166,35 @@ export default {
   fs.writeFileSync(rockConfigPath, content);
 }
 
-function updateAndroidBuildGradle(projectRoot: string, sourceDir: string) {
+export function updateAndroidBuildGradle(projectRoot: string, sourceDir: string) {
   const filePath = path.join(projectRoot, sourceDir, 'app', 'build.gradle');
   if (!fs.existsSync(filePath)) {
     return;
   }
   const desired = 'cliFile = file("../../node_modules/rock/dist/src/bin.js")';
   const content = fs.readFileSync(filePath, 'utf8');
+
+  if (content.includes(desired)) {
+    logger.debug(`${filePath} already contains "${desired}"`);
+    return;
+  }
+
   const replaced = content.replace(
-    /\/\/\s+cliFile\s*=\s*file\([^)]*\)/g,
+    /(?:\/\/\s+)?cliFile\s*=\s*file\([^)]*\)/g,
     desired,
   );
 
-  if (!content.includes(desired) && replaced !== content) {
-    fs.writeFileSync(filePath, replaced);
+  if (replaced === content) {
+    logger.warn(
+      `Unable to update ${color.bold(filePath)}. 
+Please update the "CLI file" build phase manually with:
+  cliFile = file("../../node_modules/rock/dist/src/bin.js")
+`,
+    );
     return;
   }
+
+  fs.writeFileSync(filePath, replaced);
 }
 
 function updateAndroidSettingsGradle(projectRoot: string, sourceDir: string) {