Skip to content

Commit 321b308

Browse files
committed
feat: android aab signing - adds note on sign/align sequence
1 parent 4f80eb2 commit 321b308

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/platform-android/src/lib/commands/signAndroid/signAndroid.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ export async function signAndroid(options: SignAndroidOptions) {
9494
}
9595

9696
// 4. Align archive before signing if apk
97+
// sign/align sequence is important, see https://developer.android.com/tools/zipalign
9798
const outputPath = options.outputPath ?? options.binaryPath;
9899

99100
const alignArchive = async () => {
@@ -128,6 +129,7 @@ export async function signAndroid(options: SignAndroidOptions) {
128129
loader.stop(`Signed the ${extension.toUpperCase()} file with keystore: ${colorLink(keystorePath)}.`);
129130

130131
// 6. Align archive after signing if aab
132+
// sign/align sequence is important, see https://developer.android.com/tools/zipalign
131133
if (isAab(options.binaryPath)) {
132134
await alignArchive()
133135
}

0 commit comments

Comments
 (0)