feat: android aab signing - removes --new-sdk-version from sign command

Author: mlisikbf

packages/platform-android/src/lib/commands/signAndroid/command.ts

@@ -12,7 +12,6 @@ export type SignFlags = {
   buildJsbundle?: boolean;
   jsbundle?: string;
   noHermes?: boolean;
-  minSdkVersion?: string;
 };
 
 const ARGUMENTS = [
@@ -59,10 +58,6 @@ const OPTIONS = [
     name: '--no-hermes',
     description: 'Do not use Hermes to build the JS bundle.',
   },
-  {
-    name: '--min-sdk-version',
-    description: "Override for apksigner's --min-sdk-version.",
-  },
 ];
 
 export const registerSignCommand = (api: PluginApi) => {
@@ -82,7 +77,6 @@ export const registerSignCommand = (api: PluginApi) => {
         buildJsBundle: flags.buildJsbundle,
         jsBundlePath: flags.jsbundle,
         useHermes: !flags.noHermes,
-        minSdkVersion: flags.minSdkVersion,
       });
     },
   });

packages/platform-android/src/lib/commands/signAndroid/signAndroid.ts

@@ -25,7 +25,6 @@ export type SignAndroidOptions = {
   buildJsBundle?: boolean;
   jsBundlePath?: string;
   useHermes?: boolean;
-  minSdkVersion?: string;
 };
 
 export async function signAndroid(options: SignAndroidOptions) {
@@ -111,7 +110,6 @@ export async function signAndroid(options: SignAndroidOptions) {
     keystorePassword: options.keystorePassword ?? 'pass:android',
     keyAlias: options.keyAlias,
     keyPassword: options.keyPassword,
-    minSdkVersion: options.minSdkVersion,
   });
   loader.stop(
     `Signed the ${extension.toUpperCase()} file with keystore: ${colorLink(keystorePath)}.`,
@@ -204,7 +202,6 @@ type SignOptions = {
   keystorePassword: string;
   keyAlias?: string;
   keyPassword?: string;
-  minSdkVersion?: string;
 };
 
 async function signArchive({
@@ -213,7 +210,6 @@ async function signArchive({
   keystorePassword,
   keyAlias,
   keyPassword,
-  minSdkVersion,
 }: SignOptions) {
   if (!fs.existsSync(keystorePath)) {
     throw new RockError(
@@ -240,7 +236,7 @@ Please follow instructions at: https://reactnative.dev/docs/set-up-your-environm
     formatPassword(keystorePassword),
     ...(keyAlias ? ['--ks-key-alias', keyAlias] : []),
     ...(keyPassword ? ['--key-pass', formatPassword(keyPassword)] : []),
-    ...getSdkVersionArgs(isAab(binaryPath), minSdkVersion),
+    ...(isAab(binaryPath) ? ['--min-sdk-version', '36'] : []),
     binaryPath,
   ];
 
@@ -276,16 +272,6 @@ function getSignOutputPath() {
   return path.join(getDotRockPath(), 'android/sign');
 }
 
-function getSdkVersionArgs(aab?: boolean, minSdkVersion?: string) {
-  if (!aab && !minSdkVersion) {
-    return [];
-  }
-
-  // the default here will only be applied for AABs
-  // we use a higher value as it is irrelevant for AAB verification, but allows apksigner to use better signing algorithms
-  return ['--min-sdk-version', minSdkVersion || '36'];
-}
-
 function isAab(filePath: string): boolean {
   return path.extname(filePath).toLowerCase() === '.aab';
 }

website/src/docs/cli/introduction.md

@@ -258,7 +258,6 @@ The `sign:android <binaryPath>` command signs your Android app with a keystore,
 | `--build-jsbundle`             | Build JS bundle before signing            |
 | `--jsbundle <string>`          | Path to JS bundle to apply before signing |
 | `--no-hermes`                  | Don't use Hermes for JS bundle            |
-| `--min-sdk-version`   | API level apksigner will use to determine signing strength.         |
 
 ## Platform HarmonyOS (experimental)