feat: use fs-fingerprint (#548)

* wip

* bump fs-fingerprint

* fixup

* bump fs-fingerprint

* bring back striping absolute paths

* remove processExtraSources; update docs

* take sourceDir into account; rework unnecessary rules

* remove expo/fingerprint ref

* remove preferLocal

* add support for env

* changeset

* fixup schema

* bump fs-fingerprint

* use v0.7

---------

Co-authored-by: Michał Pierzchała <[email protected]>

Author: szymonrybczak

.changeset/odd-rings-learn.md

@@ -0,0 +1,10 @@
+---
+'@rock-js/platform-apple-helpers': patch
+'@rock-js/platform-android': patch
+'@rock-js/config': patch
+'@rock-js/tools': patch
+'rock': patch
+'rock-docs': patch
+---
+
+feat: use fs-fingerprint

packages/cli/package.json

@@ -23,10 +23,10 @@
     "publish:verdaccio": "npm publish --registry http://localhost:4873 --userconfig ../../.npmrc"
   },
   "dependencies": {
-    "adm-zip": "^0.5.16",
     "@react-native-community/cli-config": "^20.0.0",
     "@rock-js/config": "^0.10.2",
     "@rock-js/tools": "^0.10.2",
+    "adm-zip": "^0.5.16",
     "commander": "^12.1.0",
     "tar": "^7.4.3",
     "tslib": "^2.3.0"

packages/cli/src/lib/plugins/fingerprint.ts

@@ -19,7 +19,7 @@ type NativeFingerprintCommandOptions = {
 
 export async function nativeFingerprintCommand(
   path: string,
-  { extraSources, ignorePaths }: FingerprintSources,
+  { extraSources, ignorePaths, env }: FingerprintSources,
   options: NativeFingerprintCommandOptions,
 ) {
   validateOptions(options);
@@ -31,14 +31,15 @@ export async function nativeFingerprintCommand(
       platform,
       extraSources,
       ignorePaths,
+      env,
     });
     console.log(fingerprint.hash);
     // log sources to stderr to avoid polluting the standard output
     console.error(
       JSON.stringify(
         {
           hash: fingerprint.hash,
-          sources: fingerprint.sources.filter((source) => source.hash != null),
+          sources: fingerprint.inputs.filter((source) => source.hash != null),
         },
         null,
         2,
@@ -57,6 +58,7 @@ export async function nativeFingerprintCommand(
     platform,
     extraSources,
     ignorePaths,
+    env,
   });
   const duration = performance.now() - start;
 
@@ -67,7 +69,7 @@ export async function nativeFingerprintCommand(
   logger.debug(
     'Sources:',
     JSON.stringify(
-      fingerprint.sources.filter((source) => source.hash != null),
+      fingerprint.inputs.filter((source) => source.hash != null),
       null,
       2,
     ),

packages/cli/src/lib/plugins/logConfig.ts

@@ -18,6 +18,8 @@ function filterConfig(config: Config) {
   // but in our case we don't install `@react-native-community/cli-platform-*` as a dependencies
   // so the config.platforms key is empty, which makes autolinking treat it as a dependency.
   delete filtered.dependencies['react-native'];
+  // we don't want to show commands in the config
+  filtered.commands = [];
   const dependencies: Record<string, DependencyConfig> = {};
   Object.keys(filtered.dependencies).forEach((item) => {
     if (isValidRNDependency(filtered.dependencies[item])) {

packages/config/src/lib/config.ts

@@ -3,7 +3,7 @@ import { createRequire } from 'node:module';
 import * as path from 'node:path';
 import { pathToFileURL } from 'node:url';
 import type { FingerprintSources, RemoteBuildCache } from '@rock-js/tools';
-import { colorLink, logger } from '@rock-js/tools';
+import { colorLink, getReactNativeVersion, logger } from '@rock-js/tools';
 import type { ValidationError } from 'joi';
 import { ConfigTypeSchema } from './schema.js';
 import { formatValidationError } from './utils.js';
@@ -71,6 +71,7 @@ export type ConfigType = {
   fingerprint?: {
     extraSources?: string[];
     ignorePaths?: string[];
+    env?: string[];
   };
 };
 
@@ -218,24 +219,6 @@ export async function getConfig(
   return outputConfig;
 }
 
-function getReactNativeVersion(root: string) {
-  try {
-    const require = createRequire(import.meta.url);
-    return JSON.parse(
-      fs.readFileSync(
-        path.join(
-          require.resolve('react-native', { paths: [root] }),
-          '..',
-          'package.json',
-        ),
-        'utf-8',
-      ),
-    ).version;
-  } catch {
-    return 'unknown';
-  }
-}
-
 function resolveReactNativePath(root: string) {
   const require = createRequire(import.meta.url);
   return path.join(require.resolve('react-native', { paths: [root] }), '..');

packages/config/src/lib/schema.ts

@@ -50,10 +50,12 @@ const ConfigTypeSchema = Joi.object({
   fingerprint: Joi.object({
     extraSources: Joi.array().items(Joi.string()).default([]),
     ignorePaths: Joi.array().items(Joi.string()).default([]),
+    env: Joi.array().items(Joi.string()).default([]),
   })
     .default({
       extraSources: [],
       ignorePaths: [],
+      env: [],
     })
     .optional(),
 }).unknown(false);

packages/platform-android/src/lib/commands/buildAndroid/buildAndroid.ts

@@ -41,6 +41,7 @@ export async function buildAndroid(
     fingerprintOptions,
   });
   const binaryPath = await getBinaryPath({
+    platformName: 'android',
     artifactName,
     localFlag: args.local,
     remoteCacheProvider,

packages/platform-android/src/lib/commands/runAndroid/runAndroid.ts

@@ -68,6 +68,7 @@ export async function runAndroid(
     fingerprintOptions,
   });
   const binaryPath = await getBinaryPath({
+    platformName: 'android',
     artifactName,
     binaryPathFlag: args.binaryPath,
     localFlag: args.local,

packages/platform-apple-helpers/src/lib/commands/build/createBuild.ts

@@ -66,6 +66,7 @@ export const createBuild = async ({
   let artifactName = await getArtifactName();
 
   const binaryPath = await getBinaryPath({
+    platformName,
     artifactName,
     localFlag: args.local,
     remoteCacheProvider,

packages/platform-apple-helpers/src/lib/commands/run/createRun.ts

@@ -66,6 +66,7 @@ export const createRun = async ({
   let artifactName = await getArtifactName();
 
   const binaryPath = await getBinaryPath({
+    platformName: 'ios',
     artifactName,
     binaryPathFlag: args.binaryPath,
     localFlag: args.local,