Skip to content

Commit 8c36f69

Browse files
committed
fixup nits from cursor review
1 parent 5b5a157 commit 8c36f69

File tree

7 files changed

+6
-8
lines changed

7 files changed

+6
-8
lines changed

packages/cli/src/lib/plugins/fingerprint.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ function validateOptions(options: NativeFingerprintCommandOptions) {
115115
options.platform !== 'harmony'
116116
) {
117117
throw new RockError(
118-
`Unsupported platform "${options.platform}". Please specify either "ios" or "android".`,
118+
`Unsupported platform "${options.platform}". Please specify either "ios", "android" or "harmony".`,
119119
);
120120
}
121121
}

packages/platform-android/src/lib/commands/runAndroid/tryInstallAppOnDevice.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export async function tryInstallAppOnDevice(
2121
let deviceId: string;
2222
if (!device.deviceId) {
2323
logger.debug(
24-
`No device with id "${device.deviceId}", skipping launching the app.`,
24+
`No "deviceId" for ${device}, skipping launching the app`,
2525
);
2626
return;
2727
} else {

packages/platform-android/src/lib/commands/runAndroid/tryLaunchAppOnDevice.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export async function tryLaunchAppOnDevice(
1212
let deviceId;
1313
if (!device.deviceId) {
1414
logger.debug(
15-
`No device with id "${device.deviceId}", skipping launching the app.`,
15+
`No "deviceId" for ${device}, skipping launching the app`,
1616
);
1717
return {};
1818
} else {

packages/platform-harmony/src/lib/commands/run/runHarmony.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ async function selectAndLaunchDevice() {
106106
const allDevices = await listHarmonyDevices();
107107
const device = await promptForDeviceSelection(allDevices);
108108

109-
console.log('sd', device);
110-
111109
if (!device.connected) {
112110
// @todo add emulators
113111
// await tryLaunchEmulator(device.readableName);

packages/platform-harmony/src/lib/commands/run/tryInstallAppOnDevice.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export async function tryInstallAppOnDevice(
2020
) {
2121
if (!device.deviceId) {
2222
logger.debug(
23-
`No device with id "${device.deviceId}", skipping launching the app.`,
23+
`No "deviceId" for ${device}, skipping launching the app`,
2424
);
2525
return;
2626
}

packages/platform-harmony/src/lib/commands/run/tryLaunchAppOnDevice.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export async function tryLaunchAppOnDevice(
1212
let deviceId;
1313
if (!device.deviceId) {
1414
logger.debug(
15-
`No device with id "${device.deviceId}", skipping launching the app.`,
15+
`No "deviceId" for ${device}, skipping launching the app`,
1616
);
1717
return {};
1818
} else {

packages/tools/src/lib/fingerprint/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export async function nativeFingerprint(
4444
const packageJSONPath = path.join(projectRoot, 'package.json');
4545
const packageJSON = await readPackageJSON(packageJSONPath);
4646
const scripts = packageJSON['scripts'];
47-
const { sourceDir } = autolinkingConfig.project[options.platform];
47+
const sourceDir = autolinkingConfig.project[options.platform]?.sourceDir;
4848

4949
if (!options.platform || !sourceDir) {
5050
throw new Error('No platforms found in autolinking project config');

0 commit comments

Comments
 (0)