Skip to content

Commit e9976d6

Browse files
committed
fix: migrate from esbuild to tsc
1 parent 5f93b07 commit e9976d6

File tree

12 files changed

+32
-71
lines changed

12 files changed

+32
-71
lines changed

nx.json

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,22 @@
1111
"default": ["sharedGlobals"]
1212
},
1313
"targetDefaults": {
14-
"@nx/esbuild:esbuild": {
14+
"@nx/js:tsc": {
1515
"cache": true,
1616
"dependsOn": ["^build"],
17-
"inputs": ["default", "^default"]
17+
"inputs": ["default", "^default"],
18+
"options": {
19+
"outputPath": "{projectRoot}/dist",
20+
"main": "{projectRoot}/src/index.ts",
21+
"tsConfig": "{projectRoot}/tsconfig.lib.json",
22+
"assets": ["packages/{projectRoot}/*.md"],
23+
"buildableProjectDepsInPackageJsonType": "dependencies",
24+
"generateExportsField": true,
25+
"compilerOptions": {
26+
"module": "ESNext",
27+
"outDir": "packages/{projectRoot}/dist"
28+
}
29+
}
1830
}
1931
},
2032
"release": {

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
},
1515
"devDependencies": {
1616
"@eslint/js": "^9.8.0",
17-
"@nx/esbuild": "^19.8.3",
1817
"@nx/eslint": "19.8.0",
1918
"@nx/eslint-plugin": "19.8.0",
2019
"@nx/js": "19.8.3",

packages/create-app/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"tags": [],
1515
"targets": {
1616
"build": {
17-
"executor": "@nx/esbuild:esbuild",
17+
"executor": "@nx/js:tsc",
1818
"options": {
1919
"outputPath": "packages/create-app/dist",
2020
"main": "packages/create-app/src/bin.ts",

packages/create-app/src/bin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#!/usr/bin/env node
2-
export * from './lib/create-app';
2+
export * from './lib/create-app.js';

packages/create-app/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export * from './lib/create-app';
1+
export * from './lib/create-app.js';

packages/create-app/src/lib/create-app.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import fs from 'node:fs';
22
import path, { dirname } from 'node:path';
3-
import editTemplate from './edit-template';
4-
import { parsePackageInfo } from './parsers';
3+
import editTemplate from './edit-template.js';
4+
import { parsePackageInfo } from './parsers.js';
55
import {
66
cancelAndExit,
77
printHelpMessage,
@@ -11,10 +11,10 @@ import {
1111
printWelcomeMessage,
1212
printByeMessage,
1313
promptTemplate,
14-
} from './prompts';
15-
import { copyDir, isEmptyDir, removeDir, resolveAbsolutePath } from './fs';
16-
import { printLogo } from './logo';
17-
import { parseCliOptions } from './parse-cli-options';
14+
} from './prompts.js';
15+
import { copyDir, isEmptyDir, removeDir, resolveAbsolutePath } from './fs.js';
16+
import { printLogo } from './logo.js';
17+
import { parseCliOptions } from './parse-cli-options.js';
1818
import { fileURLToPath } from 'node:url';
1919

2020
const TEMPLATES = ['default'];

packages/create-app/src/lib/prompts.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import {
99
} from '@clack/prompts';
1010
import fs from 'node:fs';
1111
import { dirname, join } from 'node:path';
12-
import { parsePackageManagerFromUserAgent } from './parsers';
13-
import { validateProjectName } from './validate-project-name';
12+
import { parsePackageManagerFromUserAgent } from './parsers.js';
13+
import { validateProjectName } from './validate-project-name.js';
1414
import { fileURLToPath } from 'node:url';
1515

1616
export function printHelpMessage(templates: string[]) {

packages/create-app/tsconfig.lib.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"compilerOptions": {
44
"outDir": "../../dist/out-tsc",
55
"declaration": true,
6-
"types": ["node"]
6+
"types": ["node"],
7+
"moduleResolution": "NodeNext"
78
},
89
"include": ["src/**/*.ts"],
910
"exclude": ["src/**/*.spec.ts", "src/**/*.test.ts"]

packages/create-app/tsconfig.spec.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"node",
1010
"vitest"
1111
],
12-
"module": "ESNext"
12+
"module": "NodeNext",
1313
},
1414
"include": [
1515
"vite.config.ts",

packages/test-helpers/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"executor": "@nx/js:tsc",
1010
"outputs": ["{options.outputPath}"],
1111
"options": {
12-
"outputPath": "dist/packages/test-helpers",
12+
"outputPath": "packages/test-helpers/dist",
1313
"main": "packages/test-helpers/src/index.ts",
1414
"tsConfig": "packages/test-helpers/tsconfig.lib.json",
1515
"assets": ["packages/test-helpers/*.md"]

0 commit comments

Comments
 (0)