Skip to content

Commit fc771e7

Browse files
authored
fix: download message in remote-cache --json (#340)
* fix: download message in remote-cache --json * changeset
1 parent 51316ba commit fc771e7

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@rnef/tools': patch
3+
'@rnef/cli': patch
4+
---
5+
6+
fix: download message in remote-cache --json

packages/cli/src/lib/plugins/remoteCache.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
handleDownloadResponse,
1212
logger,
1313
RnefError,
14-
spinner,
1514
} from '@rnef/tools';
1615

1716
type Flags = {
@@ -92,13 +91,7 @@ async function remoteCache({
9291
case 'download': {
9392
const localArtifactPath = getLocalArtifactPath(artifactName);
9493
const response = await remoteBuildCache.download({ artifactName });
95-
const loader = spinner();
96-
await handleDownloadResponse(
97-
response,
98-
localArtifactPath,
99-
artifactName,
100-
loader
101-
);
94+
await handleDownloadResponse(response, localArtifactPath, artifactName);
10295
const binaryPath = getLocalBinaryPath(localArtifactPath);
10396
if (!binaryPath) {
10497
throw new RnefError(`No binary found for "${artifactName}".`);

packages/tools/src/lib/build-cache/fetchCachedBuild.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export async function handleDownloadResponse(
9696
response: Response,
9797
localArtifactPath: string,
9898
name: string,
99-
loader: ReturnType<typeof spinner>
99+
loader?: ReturnType<typeof spinner>
100100
) {
101101
try {
102102
fs.mkdirSync(localArtifactPath, { recursive: true });

0 commit comments

Comments
 (0)