fix: address PR feedback (JSON output, docstrings, extensions)

Author: aviralgarg05

camel/toolkits/pptx_node_toolkit.py

@@ -56,14 +56,41 @@ def create_presentation(
         filename: str,
     ) -> str:
         r"""Create a PowerPoint presentation (PPTX) file using PptxGenJS.
+        
+        The filename MUST end with ".pptx". If it does not, the toolkit will
+        automatically append it, but the agent should strive to provide the
+        correct extension.
 
         Args:
             content (str): The content to write to the PPTX file as a JSON
-                string.
-            filename (str): The name or path of the file.
+                string. It must be a list of dictionaries representing slides.
+                
+                JSON Schema Example:
+                [
+                    {
+                        "title": "Main Title",
+                        "subtitle": "Subtitle text"
+                    },
+                    {
+                        "heading": "Slide Heading",
+                        "bullet_points": [
+                            "Point 1",
+                            "Point 2"
+                        ]
+                    },
+                    {
+                        "heading": "Table Slide",
+                        "table": {
+                            "headers": ["Col 1", "Col 2"],
+                            "rows": [["A", "B"], ["C", "D"]]
+                        }
+                    }
+                ]
+            filename (str): The name of the file to save. MUST end in .pptx.
 
         Returns:
-            str: A success message indicating the file was created.
+            str: A JSON string containing the result status, file path, and
+                number of slides generated.
         """
         if not filename.lower().endswith('.pptx'):
             filename += '.pptx'
@@ -90,12 +117,20 @@ def create_presentation(
                  text=True,
                  check=True
              )
-             res = result.stdout.strip()
-             return res
+             
+             # Parse JSON output from script
+             try:
+                 script_output = json.loads(result.stdout.strip())
+                 if script_output.get("success"):
+                     return f"Presentation created successfully. Path: {script_output.get('path')}, Slides: {script_output.get('slides')}"
+                 else:
+                     return f"Error creating presentation: {script_output.get('error')}"
+             except json.JSONDecodeError:
+                 return f"Error parsing script output: {result.stdout.strip()}"
 
         except subprocess.CalledProcessError as e:
             logger.error(f"Error creating presentation: {e.stderr}")
-            return f"Error creating presentation: {e.stderr}"
+            return f"Error creating presentation subprocess: {e.stderr}"
         except Exception as e:
             logger.error(f"Error creating presentation: {str(e)}")
             return f"Error creating presentation: {str(e)}"

camel/toolkits/scripts/generate_pptx.js

@@ -71,9 +71,18 @@ if (Array.isArray(slidesData)) {
 // Save File
 pres.writeFile({ fileName: filename })
     .then((fileName) => {
-        console.log(`PowerPoint presentation successfully created: ${fileName}`);
+        const result = {
+            success: true,
+            path: fileName,
+            slides: Array.isArray(slidesData) ? slidesData.length : 0
+        };
+        console.log(JSON.stringify(result));
     })
     .catch((err) => {
-        console.error("Error saving file:", err);
+        const result = {
+            success: false,
+            error: err.toString()
+        };
+        console.log(JSON.stringify(result));
         process.exit(1);
     });