Skip to content

Commit 41795f7

Browse files
cape2333capewaleedalzarooninitpicker55555
authored
feat: enhance hybrid_browser_toolkit to detect page loading better (#3690)
Co-authored-by: cape <[email protected]> Co-authored-by: Waleed Alzarooni <[email protected]> Co-authored-by: Puzhen Zhang <[email protected]> Co-authored-by: puzhen <[email protected]>
1 parent cdfe421 commit 41795f7

File tree

6 files changed

+395
-390
lines changed

6 files changed

+395
-390
lines changed

camel/toolkits/hybrid_browser_toolkit/config_loader.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ class BrowserConfig:
3636
screenshot_timeout: int = 15000
3737
page_stability_timeout: int = 1500
3838
dom_content_loaded_timeout: int = 5000
39+
dom_stability_threshold: int = 200
40+
dom_stability_timeout: int = 5000
3941

4042
# Viewport configuration
4143
viewport_limit: bool = False
@@ -103,6 +105,10 @@ def from_kwargs(cls, **kwargs) -> 'ConfigLoader':
103105
browser_kwargs["screenshot_timeout"] = value
104106
elif key == "pageStabilityTimeout":
105107
browser_kwargs["page_stability_timeout"] = value
108+
elif key == "domStabilityThreshold":
109+
browser_kwargs["dom_stability_threshold"] = value
110+
elif key == "domStabilityTimeout":
111+
browser_kwargs["dom_stability_timeout"] = value
106112
elif key == "domContentLoadedTimeout":
107113
browser_kwargs["dom_content_loaded_timeout"] = value
108114
elif key == "viewportLimit":
@@ -150,6 +156,10 @@ def to_ws_config(self) -> Dict[str, Any]:
150156
"networkIdleTimeout": self.browser_config.network_idle_timeout,
151157
"screenshotTimeout": self.browser_config.screenshot_timeout,
152158
"pageStabilityTimeout": self.browser_config.page_stability_timeout,
159+
"domStabilityThreshold": (
160+
self.browser_config.dom_stability_threshold
161+
),
162+
"domStabilityTimeout": self.browser_config.dom_stability_timeout,
153163
"viewport_limit": self.browser_config.viewport_limit,
154164
"connectOverCdp": self.browser_config.connect_over_cdp,
155165
"cdpUrl": self.browser_config.cdp_url,

0 commit comments

Comments
 (0)