fix: address review suggestions

Author: AlitaBernachot

packages/core/lib/utils/url.ts

@@ -18,19 +18,3 @@ export function removeSearchParams(
   toDelete.map((param) => urlObj.searchParams.delete(param));
   return urlObj.toString();
 }
-
-export function getSearchParams(
-  url: string,
-  paramNames: string[],
-): URLSearchParams {
-  const toDelete = [];
-  const urlObj = new URL(url, window.location.toString());
-  const keysLower = paramNames.map((p) => p.toLowerCase());
-  for (const param of urlObj.searchParams.keys()) {
-    if (keysLower.indexOf(param.toLowerCase()) > -1) {
-      toDelete.push(param);
-    }
-  }
-  toDelete.map((param) => urlObj.searchParams.delete(param));
-  return urlObj.searchParams;
-}

packages/maplibre/lib/map/create-map.test.ts

@@ -19,7 +19,7 @@ import {
   FEATURE_COLLECTION_POLYGON_FIXTURE_4326,
 } from "@geospatial-sdk/core/fixtures/geojson.fixtures";
 import { PartialStyleSpecification } from "../maplibre.models";
-import { GeoJSONSource, RasterSourceSpecification } from "maplibre-gl";
+import { RasterSourceSpecification } from "maplibre-gl";
 
 describe("MapContextService", () => {
   describe("#createLayer", () => {
@@ -220,7 +220,7 @@ describe("MapContextService", () => {
         expect(id).toBe("ms:commune_actuelle_3857");
         expect(source.data).toEqual(FEATURE_COLLECTION_POLYGON_FIXTURE_4326);
       });
-      it("create 3 layerS", () => {
+      it("create a layer", () => {
         expect(style.layers).toBeTruthy();
         expect(style.layers.length).toBe(1);
         const layer = style.layers[0] as RasterLayerSpecification;

packages/maplibre/lib/map/create-map.ts

@@ -39,7 +39,7 @@ export async function createLayer(
         crs: "EPSG:3857",
       });
       url = removeSearchParams(url, ["bbox"]);
-      url = `${url.toString()}&bbox={bbox-epsg-3857}`;
+      url = `${url.toString()}&BBOX={bbox-epsg-3857}`;
 
       const dataset: Dataset = {
         sources: {
@@ -66,8 +66,7 @@ export async function createLayer(
         asJson: true,
         outputCrs: "EPSG:4326",
       });
-      const geojson = await fetchGeoJson(url);
-      return createDatasetFromGeoJsonLayer(layerModel, geojson!);
+      return createDatasetFromGeoJsonLayer(layerModel, url);
     }
     case "geojson": {
       let geojson;
@@ -93,18 +92,12 @@ export async function createLayer(
       let layerUrl: string;
       if (layerModel.useTiles) {
         console.warn("[Warning] OGC API - Tiles not yet implemented.");
-        // if (layerModel.useTiles === "vector") {
-        // } else if (layerModel.useTiles === "map") {
-        // }
       } else {
         layerUrl = await ogcEndpoint.getCollectionItemsUrl(
           layerModel.collection,
           { ...layerModel.options, asJson: true },
         );
-        const geojson = await fetchGeoJson(layerUrl).catch(
-          () => featureCollection,
-        );
-        return createDatasetFromGeoJsonLayer(layerModel, geojson);
+        return createDatasetFromGeoJsonLayer(layerModel, layerUrl);
       }
       break;
     }
@@ -117,7 +110,7 @@ export async function createLayer(
 }
 
 /**
- * Create an OpenLayers map from a context; optionally specify a target (root element) for the map
+ * Create an Maplibre map from a context; optionally specify a target (root element) for the map
  * @param context
  * @param target
  */
@@ -158,13 +151,3 @@ export async function resetMapFromContext(
   }
   return map;
 }
-
-async function fetchGeoJson(url: string): Promise<FeatureCollection> {
-  const response = await fetch(url);
-  if (!response.ok) {
-    throw new Error(
-      `[Error] Maplibre.util:: ${response.status} ${response.statusText}`,
-    );
-  }
-  return await response.json();
-}

packages/maplibre/lib/map/index.ts

@@ -1,2 +1,2 @@
-export { createMapFromContext } from "./create-map";
+export { createMapFromContext, resetMapFromContext } from "./create-map";
 export { applyContextDiffToMap } from "./apply-context-diff";