fix: remove unnecessary hash comparison for view changes and use direct reference equality instead

Author: AlexianMasson

packages/core/lib/utils/map-context-diff.test.ts

@@ -8,7 +8,7 @@ import {
   SAMPLE_LAYER4,
   SAMPLE_LAYER5,
 } from "../../fixtures/map-context.fixtures";
-import { describe } from "vitest";
+import { describe, it, expect, beforeEach } from "vitest";
 
 describe("Context diff utils", () => {
   describe("computeMapContextDiff", () => {
@@ -295,6 +295,37 @@ describe("Context diff utils", () => {
           });
         });
       });
+      describe("same content but different reference", () => {
+        beforeEach(() => {
+          contextOld = {
+            ...SAMPLE_CONTEXT,
+            view: {
+              center: [5, 10],
+              zoom: 3,
+            },
+          };
+          contextNew = {
+            ...SAMPLE_CONTEXT,
+            view: {
+              center: [5, 10],
+              zoom: 3,
+            },
+          };
+        });
+        it("output the correct diff", () => {
+          diff = computeMapContextDiff(contextNew, contextOld);
+          expect(diff).toEqual({
+            layersAdded: [],
+            layersChanged: [],
+            layersRemoved: [],
+            layersReordered: [],
+            viewChanges: {
+              center: [5, 10],
+              zoom: 3,
+            },
+          });
+        });
+      });
     });
 
     describe("combined changes", () => {

packages/core/lib/utils/map-context-diff.ts

@@ -6,7 +6,6 @@ import {
   MapContextLayerReordered,
 } from "../model";
 import { isLayerSame, isLayerSameAndUnchanged } from "./map-context";
-import { getHash } from "./hash";
 
 /**
  * The following logic is produced by identifying layers in both context
@@ -92,9 +91,7 @@ export function computeMapContextDiff(
   }
 
   let viewChanges =
-    getHash(nextContext.view) !== getHash(previousContext.view)
-      ? nextContext.view
-      : undefined;
+    nextContext.view !== previousContext.view ? nextContext.view : undefined;
   if (viewChanges !== null && viewChanges !== undefined) {
     viewChanges = { ...viewChanges }; // copy the view to avoid unexpected mutations
   }