fix: address code review feedback for notebook and workflow

Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>

Author: Copilot

.github/workflows/e2e-notebook.yml

@@ -33,7 +33,7 @@ jobs:
       - name: Start Camunda 8.8 with Docker Compose
         run: |
           cd assets/c8/8.8
-          DATABASE=elasticsearch docker compose --profile elasticsearch up -d
+          docker compose --profile elasticsearch up -d
         env:
           DATABASE: elasticsearch
 
@@ -205,14 +205,14 @@ jobs:
         if: always()
         run: |
           cd assets/c8/8.8
-          DATABASE=elasticsearch docker compose --profile elasticsearch down -v
+          docker compose --profile elasticsearch down -v
         env:
           DATABASE: elasticsearch
 
       - name: Show Camunda logs on failure
         if: failure()
         run: |
           cd assets/c8/8.8
-          DATABASE=elasticsearch docker compose --profile elasticsearch logs
+          docker compose --profile elasticsearch logs
         env:
           DATABASE: elasticsearch

examples/README.md

@@ -161,8 +161,12 @@ cd assets/c8/8.8
 docker compose --profile elasticsearch up -d
 cd ../..
 
-# Run the test script
+# Run the test script (make it executable first if needed)
+chmod +x examples/test-notebook-operations.sh
 ./examples/test-notebook-operations.sh
+
+# Or run directly with bash
+bash examples/test-notebook-operations.sh
 ```
 
 This script validates all the operations demonstrated in the notebook.

examples/e2e-operations.ipynb

@@ -67,9 +67,17 @@
     "const fs = require('fs');\n",
     "const path = require('path');\n",
     "\n",
+    "// Determine repository root\n",
+    "// Note: In Jupyter kernels, __dirname may point to a temp directory.\n",
+    "// If paths don't work, adjust repoRoot to point to your c8ctl directory.\n",
+    "const repoRoot = typeof __dirname !== 'undefined' && fs.existsSync(path.join(__dirname, '..', 'package.json'))\n",
+    "  ? path.join(__dirname, '..')\n",
+    "  : process.cwd();\n",
+    "\n",
+    "console.log('Repository root:', repoRoot);\n",
+    "\n",
     "// Determine which c8ctl command to use\n",
     "const majorVersion = parseInt(process.version.slice(1).split('.')[0]);\n",
-    "const repoRoot = path.join(__dirname, '..');\n",
     "const distExists = fs.existsSync(path.join(repoRoot, 'dist', 'index.js'));\n",
     "\n",
     "let c8ctlCmd;\n",
@@ -94,6 +102,7 @@
     "        const result = execSync(cmd, { \n",
     "            encoding: 'utf8',\n",
     "            stdio: options.silent ? 'pipe' : 'inherit',\n",
+    "            cwd: repoRoot,\n",
     "            ...options \n",
     "        });\n",
     "        return result;\n",
@@ -116,8 +125,8 @@
     "console.log('Node.js version:', process.version);\n",
     "console.log('Platform:', process.platform);\n",
     "\n",
-    "// Verify we have v22 LTS\n",
-    "const majorVersion = parseInt(process.version.slice(1).split('.')[0]);\n",
+    "// Verify we have v22 LTS (reusing majorVersion from setup cell)\n",
+    "// Note: majorVersion was defined in the first cell\n",
     "if (majorVersion < 22) {\n",
     "    console.warn('⚠️  Warning: Node.js v22 or higher is recommended');\n",
     "} else {\n",
@@ -745,7 +754,7 @@
    "file_extension": ".js",
    "mimetype": "application/javascript",
    "name": "javascript",
-   "version": "22.0.0"
+   "version": "22"
   }
  },
  "nbformat": 4,