-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
Description
Acceptance Criteria (Required on creation)
MigrateDelegateBPMNErrorAndExceptionInJobWorkerhandlesExecutionListenerclasses in addition toJavaDelegateisInsideDelegateMethod()skips bothexecute()andnotify()methods to avoid transforming throw statements in original delegate methods- Test coverage for ExecutionListener classes that throw
BpmnError/ProcessEngineExceptioninsidenotify()
Hints
MigrateDelegateBPMNErrorAndExceptionInJobWorker (in MigrateExecutionRecipe.java) currently only matches classes using JavaDelegate (line 574). ExecutionListener.notify() can also throw BpmnError (see C7 test ThrowingHistoryExecutionListenerTest#shouldCatchBpmnErrorFromHistoryListenerAfterBpmnErrorInEndListenerWithErrorBoundary).
Two changes needed:
- Add
ExecutionListenerto the preconditions (line 571-574), mirroring what was done forMigrateDelegateExecutionMethodsInJobWorker - Update
isInsideDelegateMethod()(line 699-702) to also check for"notify". Without this, throw statements inside the originalnotify()method would be incorrectly transformed
Links
Breakdown
Pull Requests
Dev2QA handover
- Does this ticket need a QA test, and are the testing goals not clear from the description? Add a Dev2QA handover comment
Reactions are currently unavailable