Skip to content

Commit 599d5b4

Browse files
committed
ci: remove duplicate SaaS jobs from ci.yml (covered by release.yml)
release.yml already runs saas_integration (8.7) and saas_integration_8_8 on push to main and stable/**, with full secret access via the integration / integration-8.8 environments. The copies in ci.yml were gated to push-to-main only and ran the same commands against the same secrets — pure duplication. With CI's push trigger now scoped to stable/** (#740), the ci.yml copies would never have fired anyway. Drop them outright. Net effect: SaaS coverage is unchanged on main, and gains stable/** coverage (which release.yml already provided but the ci.yml copies did not).
1 parent 0e7e295 commit 599d5b4

1 file changed

Lines changed: 0 additions & 75 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -134,78 +134,3 @@ jobs:
134134
if: always()
135135
run: docker compose -f docker/8.9/docker-compose.yaml down
136136

137-
# SaaS integration tests hit real SaaS endpoints and require environment
138-
# secrets. To protect secret material and avoid running untrusted code
139-
# against production-like infrastructure, these only run on pushes to
140-
# `main` — i.e. after a PR has been reviewed and merged.
141-
saas_integration:
142-
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
143-
runs-on: ubuntu-latest
144-
environment: integration
145-
steps:
146-
- name: Check out the repo
147-
uses: actions/checkout@v6
148-
149-
- name: Use Node.js
150-
uses: actions/setup-node@v6
151-
with:
152-
node-version: "22"
153-
154-
- name: Install dependencies
155-
run: npm ci
156-
157-
- name: Run Integration Tests
158-
run: |
159-
npm run test:8.7:saas
160-
env:
161-
ZEEBE_REST_ADDRESS: ${{ vars.ZEEBE_REST_ADDRESS }}
162-
ZEEBE_GRPC_ADDRESS: ${{ vars.ZEEBE_GRPC_ADDRESS }}
163-
ZEEBE_CLIENT_ID: ${{ secrets.ZEEBE_CLIENT_ID }}
164-
ZEEBE_AUTHORIZATION_SERVER_URL: ${{ vars.ZEEBE_AUTHORIZATION_SERVER_URL }}
165-
ZEEBE_CLIENT_SECRET: ${{ secrets.ZEEBE_CLIENT_SECRET }}
166-
ZEEBE_TOKEN_AUDIENCE: ${{ vars.ZEEBE_TOKEN_AUDIENCE }}
167-
CAMUNDA_OAUTH_URL: ${{ vars.CAMUNDA_OAUTH_URL }}
168-
CAMUNDA_TASKLIST_BASE_URL: ${{ vars.CAMUNDA_TASKLIST_BASE_URL }}
169-
CAMUNDA_OPERATE_BASE_URL: ${{ vars.CAMUNDA_OPERATE_BASE_URL }}
170-
CAMUNDA_OPTIMIZE_BASE_URL: ${{ vars.CAMUNDA_OPTIMIZE_BASE_URL }}
171-
CAMUNDA_MODELER_BASE_URL: https://modeler.cloud.camunda.io/api
172-
CAMUNDA_CONSOLE_CLIENT_ID: ${{ secrets.CAMUNDA_CONSOLE_CLIENT_ID }}
173-
CAMUNDA_CONSOLE_CLIENT_SECRET: ${{ secrets.CAMUNDA_CONSOLE_CLIENT_SECRET }}
174-
CAMUNDA_CONSOLE_BASE_URL: ${{ vars.CAMUNDA_CONSOLE_BASE_URL }}
175-
CAMUNDA_CONSOLE_OAUTH_AUDIENCE: ${{ vars.CAMUNDA_CONSOLE_OAUTH_AUDIENCE}}
176-
177-
# SaaS 8.8 integration. Same policy as saas_integration — main pushes only.
178-
saas_integration_8_8:
179-
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
180-
runs-on: ubuntu-latest
181-
environment: integration-8.8
182-
steps:
183-
- name: Check out the repo
184-
uses: actions/checkout@v6
185-
186-
- name: Use Node.js
187-
uses: actions/setup-node@v6
188-
with:
189-
node-version: "22"
190-
191-
- name: Install dependencies
192-
run: npm ci
193-
194-
- name: Run Integration Tests
195-
run: |
196-
npm run test:8.8:saas
197-
env:
198-
ZEEBE_REST_ADDRESS: ${{ vars.ZEEBE_REST_ADDRESS }}
199-
ZEEBE_GRPC_ADDRESS: ${{ vars.ZEEBE_GRPC_ADDRESS }}
200-
ZEEBE_CLIENT_ID: ${{ secrets.ZEEBE_CLIENT_ID }}
201-
ZEEBE_AUTHORIZATION_SERVER_URL: ${{ vars.ZEEBE_AUTHORIZATION_SERVER_URL }}
202-
ZEEBE_CLIENT_SECRET: ${{ secrets.ZEEBE_CLIENT_SECRET }}
203-
ZEEBE_TOKEN_AUDIENCE: ${{ vars.ZEEBE_TOKEN_AUDIENCE }}
204-
CAMUNDA_OAUTH_URL: ${{ vars.CAMUNDA_OAUTH_URL }}
205-
CAMUNDA_TASKLIST_BASE_URL: ${{ vars.CAMUNDA_TASKLIST_BASE_URL }}
206-
CAMUNDA_OPERATE_BASE_URL: ${{ vars.CAMUNDA_OPERATE_BASE_URL }}
207-
CAMUNDA_OPTIMIZE_BASE_URL: ${{ vars.CAMUNDA_OPTIMIZE_BASE_URL }}
208-
CAMUNDA_MODELER_BASE_URL: https://modeler.cloud.camunda.io/api
209-
CAMUNDA_CONSOLE_CLIENT_ID: ${{ secrets.CAMUNDA_CONSOLE_CLIENT_ID }}
210-
CAMUNDA_CONSOLE_CLIENT_SECRET: ${{ secrets.CAMUNDA_CONSOLE_CLIENT_SECRET }}
211-
CAMUNDA_CONSOLE_BASE_URL: ${{ vars.CAMUNDA_CONSOLE_BASE_URL }}

0 commit comments

Comments
 (0)