Skip to content

Commit 1b4b994

Browse files
ci: remove integration test --test-it infrastructure (#6043)
Co-authored-by: hisImminence <55736962+hisImminence@users.noreply.github.com>
1 parent 5f91fd5 commit 1b4b994

34 files changed

Lines changed: 107 additions & 108 deletions

File tree

.github/actions/generate-chart-matrix/action.yaml

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,37 @@ runs:
7878
- name: Get chart versions
7979
id: get-chart-versions
8080
uses: ./.github/actions/get-chart-versions
81+
- name: Restore deploy-camunda binary
82+
id: binary-cache
83+
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
84+
with:
85+
path: ~/.local/bin/deploy-camunda
86+
key: deploy-camunda-v2-${{ runner.os }}-${{ hashFiles('scripts/deploy-camunda/**/*.go', 'scripts/deploy-camunda/go.sum') }}
8187
- name: Setup Go
88+
if: steps.binary-cache.outputs.cache-hit != 'true'
8289
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
8390
with:
8491
go-version-file: scripts/deploy-camunda/go.mod
8592
cache: true
8693
cache-dependency-path: scripts/deploy-camunda/go.sum
8794
- name: Build deploy-camunda
95+
if: steps.binary-cache.outputs.cache-hit != 'true'
8896
shell: bash
8997
run: |
9098
mkdir -p "$HOME/.local/bin"
91-
(cd scripts/deploy-camunda && go build -o "$HOME/.local/bin/deploy-camunda" .)
92-
echo "$HOME/.local/bin" >> "$GITHUB_PATH"
99+
# CGO_ENABLED=0 produces a static binary so it runs unchanged inside the
100+
# ci-runner container used by downstream matrix jobs.
101+
(cd scripts/deploy-camunda && CGO_ENABLED=0 go build -o "$HOME/.local/bin/deploy-camunda" .)
102+
- name: Export deploy-camunda to PATH
103+
shell: bash
104+
run: echo "$HOME/.local/bin" >> "$GITHUB_PATH"
105+
- name: Upload deploy-camunda binary
106+
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
107+
with:
108+
name: deploy-camunda-binary
109+
path: ~/.local/bin/deploy-camunda
110+
if-no-files-found: error
111+
retention-days: 1
93112
- name: Generate matrix
94113
shell: bash
95114
id: set-chart-versions

.github/workflows/renovate-config-check.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,11 @@ jobs:
2929
args: renovate-config-validator
3030

3131
- name: Set up Go
32-
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
32+
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
3333
with:
3434
go-version-file: scripts/renovate-config-check/go.mod
35+
cache: true
36+
cache-dependency-path: scripts/renovate-config-check/go.sum
3537

3638
- name: Validate alpha versioning consistency
3739
working-directory: scripts/renovate-config-check

.github/workflows/test-chart-version-template.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,6 @@ on:
117117
required: false
118118
default: false
119119
type: boolean
120-
skip-it:
121-
description: "Skip integration (Playwright IT) tests for this scenario"
122-
required: false
123-
default: false
124-
type: boolean
125120
helm-version:
126121
description: "Helm version to install. Empty means use the pre-baked Helm from the CI runner image."
127122
required: false
@@ -219,7 +214,6 @@ jobs:
219214
test-qa: ${{ inputs.test-qa }}
220215
test-upgrade: ${{ inputs.test-upgrade }}
221216
skip-e2e: ${{ inputs.skip-e2e }}
222-
skip-it: ${{ inputs.skip-it }}
223217
helm-version: ${{ inputs.helm-version }}
224218
pr-head-sha: ${{ inputs.pr-head-sha }}
225219
camunda-version: ${{ inputs.camunda-version }}

.github/workflows/test-chart-version.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,11 @@ jobs:
191191
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
192192
with:
193193
go-version-file: scripts/ci-result-cache/go.mod
194-
cache: true
195-
cache-dependency-path: scripts/ci-result-cache/go.sum
194+
# Cache disabled: the previous setup-go invocation (in the
195+
# generate-chart-matrix composite) already populated GOMODCACHE
196+
# with overlapping packages. Restoring a second cache on top of
197+
# the first triggers tar "File exists" errors.
198+
cache: false
196199

197200
- name: Annotate matrix with cache status
198201
id: annotate-cache
@@ -299,7 +302,6 @@ jobs:
299302
test-qa: ${{ matrix.qa == 'true' }}
300303
test-upgrade: ${{ matrix.upgrade == 'true' }}
301304
skip-e2e: ${{ matrix.skipE2E == 'true' }}
302-
skip-it: ${{ matrix.skipIT == 'true' }}
303305
helm-version: ${{ matrix.helmVersion }}
304306
cached: ${{ matrix.cached == 'true' }}
305307
pr-head-sha: ${{ needs.init.outputs.pr-head-sha }}

.github/workflows/test-integration-runner.yaml

Lines changed: 38 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,6 @@ on:
139139
required: false
140140
default: false
141141
type: boolean
142-
skip-it:
143-
description: "Skip integration (Playwright IT) tests for this scenario (declared in ci-test-config.yaml)"
144-
required: false
145-
default: false
146-
type: boolean
147142
pr-head-sha:
148143
description: "PR HEAD commit SHA for recording cache results"
149144
required: false
@@ -337,6 +332,16 @@ jobs:
337332
- name: CI Setup - Configure Git safe directory
338333
run: git config --global --add safe.directory "${GITHUB_WORKSPACE}"
339334

335+
- name: Download deploy-camunda binary
336+
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
337+
with:
338+
name: deploy-camunda-binary
339+
path: ${{ runner.temp }}/bin
340+
- name: Add deploy-camunda to PATH
341+
run: |
342+
chmod +x "${RUNNER_TEMP}/bin/deploy-camunda"
343+
echo "${RUNNER_TEMP}/bin" >> "$GITHUB_PATH"
344+
340345
- name: Configure curl and wget
341346
uses: ./.github/actions/setup-curl
342347

@@ -520,11 +525,10 @@ jobs:
520525
run: |
521526
echo "Extra values from workflow:"
522527
echo "$EXTRA_VALUES" | tee /tmp/extra-values-file.yaml
523-
cd ./scripts/deploy-camunda
524-
go run . entra update-redirect-uris \
528+
deploy-camunda entra update-redirect-uris \
525529
--ingress-host "$TEST_INGRESS_HOST" \
526530
--log-level info
527-
go run . entra ensure-venom-app \
531+
deploy-camunda entra ensure-venom-app \
528532
--namespace "$TEST_NAMESPACE" \
529533
--log-level info | tee /tmp/entra-output.txt
530534
# Capture VENOM_CLIENT_ID and CONNECTORS_CLIENT_ID from Go CLI stdout.
@@ -675,8 +679,7 @@ jobs:
675679
EXTRA_VALUES_ARGS=(--extra-values /tmp/extra-values-file.yaml)
676680
fi
677681
678-
cd ./scripts/deploy-camunda
679-
go run . matrix run \
682+
deploy-camunda matrix run \
680683
--repo-root "${GITHUB_WORKSPACE}" \
681684
--include-disabled \
682685
--scenario-filter "${{ inputs.scenario }}" \
@@ -792,6 +795,16 @@ jobs:
792795
- name: CI Setup - Configure Git safe directory
793796
run: git config --global --add safe.directory "${GITHUB_WORKSPACE}"
794797

798+
- name: Download deploy-camunda binary
799+
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
800+
with:
801+
name: deploy-camunda-binary
802+
path: ${{ runner.temp }}/bin
803+
- name: Add deploy-camunda to PATH
804+
run: |
805+
chmod +x "${RUNNER_TEMP}/bin/deploy-camunda"
806+
echo "${RUNNER_TEMP}/bin" >> "$GITHUB_PATH"
807+
795808
# Tools (golang, helm, kubectl, oc, task, yq, zbctl) are pre-installed in the CI runner container image
796809
# See: .github/docker/ci-runner/Dockerfile
797810
# The per-scenario helm-version input below can override the pre-baked helm when set in ci-test-config.yaml.
@@ -887,11 +900,10 @@ jobs:
887900
run: |
888901
echo "Extra values from workflow:"
889902
echo "$EXTRA_VALUES" | tee /tmp/extra-values-file.yaml
890-
cd ./scripts/deploy-camunda
891-
go run . entra update-redirect-uris \
903+
deploy-camunda entra update-redirect-uris \
892904
--ingress-host "$TEST_INGRESS_HOST" \
893905
--log-level info
894-
go run . entra ensure-venom-app \
906+
deploy-camunda entra ensure-venom-app \
895907
--namespace "$TEST_NAMESPACE" \
896908
--log-level info | tee /tmp/entra-output.txt
897909
# Capture VENOM_CLIENT_ID and CONNECTORS_CLIENT_ID from Go CLI stdout.
@@ -1029,8 +1041,7 @@ jobs:
10291041
# scenario injection is tracked in #6312. (The install flow, being single-
10301042
# step, forwards the file safely; see that step.)
10311043
1032-
cd ./scripts/deploy-camunda
1033-
go run . matrix run \
1044+
deploy-camunda matrix run \
10341045
--repo-root "${GITHUB_WORKSPACE}" \
10351046
--include-disabled \
10361047
--scenario-filter "${{ inputs.scenario }}" \
@@ -1461,6 +1472,16 @@ jobs:
14611472
- name: CI Setup - Configure Git safe directory
14621473
run: git config --global --add safe.directory "${GITHUB_WORKSPACE}"
14631474

1475+
- name: Download deploy-camunda binary
1476+
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
1477+
with:
1478+
name: deploy-camunda-binary
1479+
path: ${{ runner.temp }}/bin
1480+
- name: Add deploy-camunda to PATH
1481+
run: |
1482+
chmod +x "${RUNNER_TEMP}/bin/deploy-camunda"
1483+
echo "${RUNNER_TEMP}/bin" >> "$GITHUB_PATH"
1484+
14641485
- name: CI Setup - ℹ️ Set workflow vars for both install and upgrade ℹ️
14651486
id: vars
14661487
uses: ./.github/actions/workflow-vars
@@ -1542,8 +1563,7 @@ jobs:
15421563
ENTRA_APP_OBJECT_ID: ${{ steps.test-credentials-secret.outputs.ENTRA_APP_OBJECT_ID }}
15431564
ENTRA_APP_DIRECTORY_ID: ${{ steps.test-credentials-secret.outputs.ENTRA_APP_DIRECTORY_ID }}
15441565
run: |
1545-
cd ./scripts/deploy-camunda
1546-
go run . entra cleanup-venom-app \
1566+
deploy-camunda entra cleanup-venom-app \
15471567
--namespace "$TEST_NAMESPACE" \
15481568
--log-level info
15491569
@@ -1559,8 +1579,7 @@ jobs:
15591579
AUTH0_MGMT_CLIENT_ID: ${{ steps.test-credentials-secret.outputs.AUTH0_MGMT_CLIENT_ID }}
15601580
AUTH0_MGMT_CLIENT_SECRET: ${{ steps.test-credentials-secret.outputs.AUTH0_MGMT_CLIENT_SECRET }}
15611581
run: |
1562-
cd ./scripts/deploy-camunda
1563-
go run . auth0 cleanup-clients \
1582+
deploy-camunda auth0 cleanup-clients \
15641583
--namespace "$TEST_NAMESPACE" \
15651584
--domain "$AUTH0_DOMAIN" \
15661585
--log-level info

.github/workflows/test-integration-template.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,11 @@ on:
131131
default: false
132132
type: boolean
133133
skip-it:
134-
description: "Skip integration (Playwright IT) tests for this scenario"
134+
# Deprecated no-op: kept so existing external callers (camunda/camunda,
135+
# camunda/identity, camunda/connectors, …) don't fail on unknown-input.
136+
# The integration test runner was removed; remove this input once
137+
# downstream repos stop passing it.
138+
description: "Deprecated — no-op. The --test-it runner was removed."
135139
required: false
136140
default: false
137141
type: boolean
@@ -374,7 +378,6 @@ jobs:
374378
test-qa: ${{ inputs.test-qa }}
375379
test-upgrade: ${{ inputs.test-upgrade }}
376380
skip-e2e: ${{ inputs.skip-e2e }}
377-
skip-it: ${{ inputs.skip-it }}
378381
pr-head-sha: ${{ inputs.pr-head-sha }}
379382
camunda-version: ${{ inputs.camunda-version }}
380383
camunda-helm-post-render: ${{ inputs.camunda-helm-post-render }}

charts/camunda-platform-8.10/test/ci/registry-snapshot.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ integration:
227227
features:
228228
- postgresql-companion
229229
skip-e2e: true
230-
skip-it: true
231230
dependencies:
232231
- chart: charts/internal-postgresql
233232
release-name: postgresql
@@ -474,7 +473,6 @@ integration:
474473
features:
475474
- no-secondary-storage
476475
skip-e2e: true
477-
skip-it: true
478476
dependencies:
479477
- chart: charts/internal-keycloak-26
480478
release-name: keycloak

charts/camunda-platform-8.10/test/ci/registry/scenarios/no-secondary-storage.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ platforms:
1111
infra-type:
1212
gke: distroci
1313
skip-e2e: true
14-
skip-it: true
1514
dependencies:
1615
- keycloak
1716
- postgresql

charts/camunda-platform-8.10/test/ci/registry/scenarios/oidc.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ infra-type:
1616
eks: preemptible
1717
gke: distroci
1818
skip-e2e: true
19-
skip-it: true
2019
dependencies:
2120
- postgresql
2221
- elasticsearch

charts/camunda-platform-8.7/test/ci/registry-snapshot.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ integration:
8585
persistence: elasticsearch
8686
helmVersion: 3.20.2
8787
skip-e2e: true
88-
skip-it: true
8988
- name: keycloak-original
9089
enabled: true
9190
shortname: keyc

0 commit comments

Comments
 (0)