Skip to content

Commit 533b85a

Browse files
eamonnmoloneyhisImminence
authored andcommitted
ci: remove sudo from playwright-e2e-tests container action
The playwright-runner container runs as root but does not have sudo installed, causing 'sudo: command not found' failures in CI. - Replace sudo with direct commands in apt-get/rm/sed calls - Disable build-essential-enabled in common-tooling (prevents sudo apt install build-essential, which Playwright tests don't need)
1 parent b37bb34 commit 533b85a

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

.github/actions/playwright-e2e-tests/action.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,10 @@ runs:
6969
fi
7070
7171
# Install gettext for envsubst command used by render-e2e-env.sh
72+
# Note: no sudo — containers run as root, and sudo may not be installed.
7273
if command -v apt-get &> /dev/null; then
7374
install_packages() {
74-
sudo apt-get update && sudo apt-get install -y gettext-base
75+
apt-get update && apt-get install -y gettext-base
7576
}
7677
7778
# Try up to 5 times with exponential backoff
@@ -84,14 +85,14 @@ runs:
8485
8586
if [ $attempt -lt 5 ]; then
8687
echo "apt-get failed, cleaning cache and retrying in $((attempt * 30)) seconds..."
87-
sudo rm -rf /var/lib/apt/lists/*
88+
rm -rf /var/lib/apt/lists/*
8889
sleep $((attempt * 30))
8990
9091
# On third attempt, try switching to a different mirror
9192
if [ $attempt -eq 3 ]; then
9293
echo "Switching to alternative Ubuntu mirror..."
93-
sudo sed -i 's|http://archive.ubuntu.com|http://mirrors.edge.kernel.org|g' /etc/apt/sources.list 2>/dev/null || true
94-
sudo sed -i 's|http://security.ubuntu.com|http://mirrors.edge.kernel.org|g' /etc/apt/sources.list 2>/dev/null || true
94+
sed -i 's|http://archive.ubuntu.com|http://mirrors.edge.kernel.org|g' /etc/apt/sources.list 2>/dev/null || true
95+
sed -i 's|http://security.ubuntu.com|http://mirrors.edge.kernel.org|g' /etc/apt/sources.list 2>/dev/null || true
9596
fi
9697
else
9798
echo "All attempts failed"
@@ -119,7 +120,7 @@ runs:
119120
uses: camunda/infra-global-github-actions/common-tooling@28e9ac0ffb3c71c7a1aaa989d5abdad0738c0436 # main
120121
with:
121122
overwrite: "false"
122-
build-essential-enabled: "true"
123+
build-essential-enabled: "false"
123124
node-enabled: "true"
124125
yarn-enabled: "false"
125126
buildx-enabled: "false"

0 commit comments

Comments
 (0)