fix: update migration job labels so requests are not routed to them (#4143)

Author: hamza-m-masood

charts/camunda-platform-8.8/templates/orchestration/_helpers.tpl

@@ -21,6 +21,15 @@ app.kubernetes.io/component: zeebe-broker
 app.kubernetes.io/version: {{ include "camundaPlatform.versionLabel" (dict "base" .Values.global "overlay" .Values.orchestration "chart" .Chart) | quote }}
 {{- end }}
 
+{{/*
+[orchestration] Defines extra labels for orchestration.
+*/}}
+{{ define "orchestrationMigration.extraLabels" -}}
+{{- /* NOTE: The value is set to "zeebe-broker" for backward compatibility between 8.7 and 8.8. */ -}}
+app.kubernetes.io/component: orchestration-migration
+app.kubernetes.io/version: {{ include "camundaPlatform.versionLabel" (dict "base" .Values.global "overlay" .Values.orchestration "chart" .Chart) | quote }}
+{{- end }}
+
 {{/*
 [orchestration Importer] Defines extra labels for orchestration importer.
 */}}
@@ -39,6 +48,15 @@ app.kubernetes.io/version: {{ include "camundaPlatform.versionLabel" (dict "base
     {{- include "orchestration.extraLabels" . }}
 {{- end -}}
 
+{{/*
+[orchestration] Define common labels for orchestration cluster migrations, combining the match labels and transient labels, which might change on updating
+(version depending). These labels shouldn't be used on matchLabels selector, since the selectors are immutable.
+*/}}
+{{- define "orchestrationMigration.labels" -}}
+    {{- include "camundaPlatform.labels" . }}
+    {{- "\n" }}
+    {{- include "orchestrationMigration.extraLabels" . }}
+{{- end -}}
 
 {{/*
 [orchestration Importer] Define common labels for orchestration importer, combining the match labels and transient labels, which might change on updating

charts/camunda-platform-8.8/templates/orchestration/migration-data-job.yaml

@@ -3,14 +3,14 @@ apiVersion: batch/v1
 kind: Job
 metadata:
   name: {{ include "orchestration.fullname" . }}-data-migration
-  labels: {{- include "orchestration.labels" . | nindent 4 }}
+  labels: {{- include "orchestrationMigration.labels" . | nindent 4 }}
   annotations: {{- toYaml .Values.global.annotations | nindent 4 }}
 spec:
   backoffLimit: {{ .Values.orchestration.migration.data.backoffLimit }}
   template:
     metadata:
       labels:
-        {{- include "orchestration.labels" . | nindent 8 }}
+        {{- include "orchestrationMigration.labels" . | nindent 8 }}
       annotations:
         checksum/config: {{ include (print $.Template.BasePath "/orchestration/migration-data-configmap.yaml") . | sha256sum }}
     spec:

charts/camunda-platform-8.8/templates/orchestration/migration-identity-job.yaml

@@ -3,14 +3,14 @@ apiVersion: batch/v1
 kind: Job
 metadata:
   name: {{ include "identity.fullname" . }}-migration
-  labels: {{- include "orchestration.labels" . | nindent 4 }}
+  labels: {{- include "orchestrationMigration.labels" . | nindent 4 }}
   annotations: {{- toYaml .Values.global.annotations | nindent 4 }}
 spec:
   backoffLimit: {{ .Values.orchestration.migration.identity.backoffLimit }}
   template:
     metadata:
       labels:
-        {{- include "orchestration.labels" . | nindent 8 }}
+        {{- include "orchestrationMigration.labels" . | nindent 8 }}
       annotations:
         checksum/config: {{ include (print $.Template.BasePath "/orchestration/migration-identity-configmap.yaml") . | sha256sum }}
     spec: