Skip to content

[ISSUE] issues with the introduction of 8.7 e2e tests for every PR run #3809

@hamza-m-masood

Description

@hamza-m-masood

Describe the issue:

I am basing my findings on this merged PR: #3730

Here are the current issues:

  • confusing naming of inputs: run-all-e2e-tests, e2e-enabled
    It is not clear from just the names what these inputs do. It would be best to change the names and provide an adequate description.
  • The parse-platform step is not needed the test-chart-version-template since this step was already done previously in test-integration-template. Also, the command in this step uses jq to parse the input when the input's default value is just gke. Previously it was possible to specify many platforms using the platforms input as seen here
  • Previously these TEST_HELM_EXTRA_ARGS values existed. But now they are removed. This breaks the OpenSearc scenario.
  • The default scenario should be named elasticsearch and not base, as it was previously. Since we don't have a scenario file with a base suffix and it does not make sense to have a base scenario since the naming is ambiguous.
  • There is no need to have CI_HOSTNAME_BASE as the env var since it is already taken care of in the workflow-vars action.
  • In my opinion, it is better to change the name back to init from ci-setup because we use init as a standard in our team across other workflows.
  • Why is it needed to mention ingress-hostname-base here? It was not needed before.
  • I'm not sure what this enterprise input was used for before but it is removed. I would like to know why it is removed.

Further thoughts:
The nightly integration tests are failing. It is quite possible that these changes made the nightly tests to fail. It would be good to look over that workflow and see what need to be changed.
Actual behavior:

Expected behavior:

How to reproduce:

Logs:

Environment:

Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

  • Platform:
  • Helm CLI version:
  • Chart version:
  • Values file:

Metadata

Metadata

Assignees

Labels

P1Important issues that, while not blocking progress like P0, still hold significance in the roadmap.area/cikind/issueUnidentified issue, it could be a bug, misconfig, or anything in betweenplatform/awsIssues related to AWSplatform/gcpIssues related to GCPsize/s<1 week

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions