feat: simplify env handling

Author: monavari-lebrecht

.github/workflows/webapp-e2e-tests-on-demand.yml

@@ -17,7 +17,7 @@ on:
 
 permissions:
   contents: read
-  actions: write  # Needed for upload-artifact@v4
+  actions: write # Needed for upload-artifact@v4
 
 jobs:
   generate-matrix:
@@ -68,26 +68,9 @@ jobs:
           echo "CONFIG_PATH=${{ matrix.config_path }}" >> "$GITHUB_ENV"
           echo "NON_STANDALONE=${{ matrix.non_standalone }}" >> "$GITHUB_ENV"
           echo "Load environment variables from config path..."
-          ENV_FILE_ABS="$GITHUB_WORKSPACE/${{ matrix.config_path }}/env"
-          ENV_FILE_REL="env"
-          if [[ -f "$ENV_FILE_ABS" ]]; then
-            if [[ ! -f "${{ matrix.config_path }}/.env" ]]; then
-              echo "Creating .env from env in ${{ matrix.config_path }}"
-              cp "$ENV_FILE_ABS" "$GITHUB_WORKSPACE/${{ matrix.config_path }}/.env"
-            fi
-          else
-            ENV_FILE_ABS="$GITHUB_WORKSPACE/${{ matrix.config_path }}/envs/.env.database.elasticsearch"
-            ENV_FILE_REL="envs/.env.database.elasticsearch"
-            if [[ -f "$ENV_FILE_ABS" ]]; then
-              echo "Using env file for 8.8/8.9: $ENV_FILE_ABS"
-              echo "DATABASE=elasticsearch" >> "$GITHUB_ENV"
-            else
-              echo "No env file found in ${{ matrix.config_path }}"
-              exit 1
-            fi
-          fi
-          echo "ENV_FILE_ABS=$ENV_FILE_ABS" >> "$GITHUB_ENV"
-          echo "ENV_FILE_REL=$ENV_FILE_REL" >> "$GITHUB_ENV"
+          if [[ ! -f "${{ matrix.config_path }}/.env" ]]; then
+            echo "Creating .env from env in ${{ matrix.config_path }}"
+            cp "${{ matrix.config_path }}/env" "${{ matrix.config_path }}/.env"
           # Filter out comments and empty lines before adding to GITHUB_ENV
           grep -v '^#' "$ENV_FILE_ABS" | grep -v '^$' >> "$GITHUB_ENV"
           echo "=== Loaded environment variables ==="
@@ -133,13 +116,13 @@ jobs:
               CAMUNDA_SECURITY_AUTHENTICATION_UNPROTECTEDAPI=true \
               CAMUNDA_SECURITY_AUTHORIZATIONS_ENABLED=false \
               CAMUNDA_SECURITY_AUTHENTICATION_METHOD=NONE \
-              DATABASE=elasticsearch docker compose up -d camunda
+              DATABASE=elasticsearch docker compose --env-file "$ENV_FILE_REL" up -d camunda
             else
               echo "Starting with default Tasklist V2 mode"
               CAMUNDA_SECURITY_AUTHENTICATION_UNPROTECTEDAPI=true \
               CAMUNDA_SECURITY_AUTHORIZATIONS_ENABLED=false \
               CAMUNDA_SECURITY_AUTHENTICATION_METHOD=NONE \
-              DATABASE=elasticsearch docker compose up -d camunda
+              DATABASE=elasticsearch docker compose --env-file "$ENV_FILE_REL" up -d camunda
             fi
           fi
         working-directory: ${{ env.CONFIG_PATH }}
@@ -205,7 +188,7 @@ jobs:
           node-version: 22
           cache: npm
         env:
-          ACTIONS_STEP_DEBUG: 'false'
+          ACTIONS_STEP_DEBUG: "false"
 
       - name: Clean install dependencies
         shell: bash
@@ -260,34 +243,33 @@ jobs:
       - name: Start webserver and run E2E tests
         shell: bash
         env:
-
           CAMUNDA_TASKLIST_V2_MODE_ENABLED: ${{ matrix.tasklist_mode == 'v2' && 'true' || 'false' }}
         run: |
           set -euo pipefail
           echo "Starting local webserver with debug output..."
-          
+
           # Ensure node_modules/.bin is in PATH for npm-run-all to find binaries
           export PATH="$PWD/node_modules/.bin:$PATH"
-          
+
           # Create logs directory in workspace for act compatibility
           mkdir -p ./logs
-          
+
           # Start router in background with full output capture
           # Use :ci variant to disable livereload and avoid port conflicts
           npm run start:local:ci > ./logs/web.log 2>&1 &
           WEB_PID=$!
           echo $WEB_PID > ./logs/web.pid
           echo "Webserver PID: $WEB_PID"
           sleep 15
-          
+
           # Check if process is still alive
           if ! kill -0 $WEB_PID 2>/dev/null; then
             echo "ERROR: Webserver crashed!"
             echo "=== Last 150 lines from web.log ==="
             tail -n 150 ./logs/web.log || true
             exit 1
           fi
-          
+
           # Poll for server readiness with longer timeout
           echo "Polling for server readiness..."
           for i in {1..60}; do
@@ -304,7 +286,7 @@ jobs:
             echo "Wait $i/60..."
             sleep 2
           done
-          
+
           # Verify server is responsive
           HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" http://127.0.0.1:5001/app/index.html 2>/dev/null || echo "000")
           if [[ "$HTTP_CODE" == "000" ]]; then
@@ -319,14 +301,14 @@ jobs:
             exit 1
           fi
           echo "✓ Server is ready!"
-          
+
           # Log Camunda container status
           echo ""
           echo "=== Camunda Container Status ==="
           docker ps | grep camunda || echo "Camunda container not found"
           docker logs camunda 2>&1 | tail -n 20 || echo "Could not get Camunda logs"
           echo ""
-          
+
           # Test Zeebe connectivity
           echo "=== Testing Zeebe Connectivity ==="
           timeout 5 bash -c 'echo > /dev/tcp/127.0.0.1/26500' && echo "✓ Port 26500 is open" || echo "✗ Port 26500 is closed"
@@ -366,10 +348,10 @@ jobs:
             sleep 2
           done
           echo ""
-          
+
           # Deploy forms before tests (continue even if some forms fail)
           npm run e2e:test:deployForms || true
-          
+
           echo ""
           echo "=== Starting Playwright E2E Tests with Debug Info ==="
           npm run e2e:test 2>&1 | tee -a ./logs/test-output.log || true
@@ -393,4 +375,4 @@ jobs:
             fiori-app/webapp/test-results
             logs/web.log
             logs/test-output.log
-          retention-days: 10
+          retention-days: 10