fix: do not show link if onConfigureConnection not provided

Author: philippfromme

lib/components/Output/Output.jsx

@@ -231,14 +231,14 @@ function ErrorBanner({
   description,
   actionLabel,
   actionUrl = '#',
-  onActionClick = () => {}
+  onActionClick
 }) {
   return (
     <div className="output__error">
       <div className="output__error--title">
         <span>{title}</span>
         {
-          actionLabel && <div className="output__error--action">
+          actionLabel && onActionClick && <div className="output__error--action">
             <Link href={ actionUrl } onClick={ () => onActionClick() }>
               { actionLabel }
             </Link>

test/components/Output/Output.spec.js

@@ -36,6 +36,45 @@ describe('Output', function() {
   });
 
 
+  describe('error banner', function() {
+
+    it('should render action link when onConfigureConnection is provided', async function() {
+
+      // when
+      const { queryByText } = renderWithProps({
+        isConnectionConfigured: false,
+        configureConnectionBannerTitle: 'Foo',
+        configureConnectionBannerDescription: 'Bar',
+        configureConnectionLabel: 'Baz',
+        onConfigureConnection: () => {}
+      });
+
+      // then
+      expect(queryByText(/Foo/i)).to.exist;
+      expect(queryByText(/Bar/i)).to.exist;
+      expect(queryByText(/Baz/i)).to.exist;
+    });
+
+
+    it('should not render action link when onConfigureConnection is not provided', async function() {
+
+      // when
+      const { queryByText } = renderWithProps({
+        isConnectionConfigured: false,
+        configureConnectionBannerTitle: 'Foo',
+        configureConnectionBannerDescription: 'Bar',
+        configureConnectionLabel: 'Baz'
+      });
+
+      // then
+      expect(queryByText(/Foo/i)).to.exist;
+      expect(queryByText(/Bar/i)).to.exist;
+      expect(queryByText(/Baz/i)).to.not.exist;
+    });
+
+  });
+
+
   describe('pickVariables', function() {
 
     it('should pick variables by scope', function() {
@@ -162,7 +201,7 @@ function renderWithProps(props) {
     configureConnectionBannerTitle = 'Configure Connection',
     configureConnectionBannerDescription = 'Please configure your connection settings.',
     configureConnectionLabel = 'Configure Connection',
-    onConfigureConnection = () => {},
+    onConfigureConnection,
     isTaskExecuting = false,
     output = {},
     onResetOutput = () => {},