Skip to content

Commit d124045

Browse files
philippfrommejarekdanielak
authored andcommitted
feat: make no connection banner configurable
1 parent 5a09871 commit d124045

File tree

3 files changed

+27
-3
lines changed

3 files changed

+27
-3
lines changed

demo/App.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,9 @@ function App() {
232232
<TestTab
233233
injector={ injector }
234234
isConnectionConfigured={ isConnectionConfigured }
235+
configureConnectionBannerTitle="Not prompted yet"
236+
configureConnectionBannerDescription="Click Configure, then Ok when prompted."
237+
configureConnectionLabel="Get prompted"
235238
onConfigureConnection={ () => {
236239
if (window.confirm('Can execute task?')) {
237240
setIsConnectionConfigured(true);

lib/components/Output/Output.jsx

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ export const TASK_EXECUTION_STATUS_LABEL = {
3030
/**
3131
* @param {Object} props
3232
* @param {boolean} props.isConnectionConfigured
33+
* @param {string} [props.configureConnectionBannerTitle]
34+
* @param {string} [props.configureConnectionBannerDescription]
35+
* @param {string} [props.configureConnectionLabel]
3336
* @param {Function} [props.onConfigureConnection]
3437
* @param {boolean} props.isTaskExecuting
3538
* @param {import('../../types').ElementOutput} props.output
@@ -38,6 +41,9 @@ export const TASK_EXECUTION_STATUS_LABEL = {
3841
*/
3942
export default function Output({
4043
isConnectionConfigured,
44+
configureConnectionBannerTitle,
45+
configureConnectionBannerDescription,
46+
configureConnectionLabel,
4147
onConfigureConnection,
4248
isTaskExecuting,
4349
output,
@@ -91,6 +97,9 @@ export default function Output({
9197
<div className="output__body">
9298
<OutputBanner
9399
isConnectionConfigured={ isConnectionConfigured }
100+
configureConnectionBannerTitle={ configureConnectionBannerTitle }
101+
configureConnectionBannerDescription={ configureConnectionBannerDescription }
102+
configureConnectionLabel={ configureConnectionLabel }
94103
onConfigureConnection={ onConfigureConnection }
95104
output={ output }
96105
/>
@@ -108,15 +117,18 @@ export default function Output({
108117

109118
function OutputBanner({
110119
isConnectionConfigured,
120+
configureConnectionBannerTitle,
121+
configureConnectionBannerDescription,
122+
configureConnectionLabel,
111123
onConfigureConnection,
112124
output
113125
}) {
114126

115127
if (!isConnectionConfigured) {
116128
return <ErrorBanner
117-
title="Connection required"
118-
description="Configure a connection to start testing."
119-
actionLabel="Configure"
129+
title={ configureConnectionBannerTitle }
130+
description={ configureConnectionBannerDescription }
131+
actionLabel={ configureConnectionLabel }
120132
onActionClick={ onConfigureConnection }
121133
/>;
122134
}

lib/components/TaskTesting/TaskTesting.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ export const NO_ELEMENT_TEXT = 'Select a task to start testing';
3232
* @param {Object} props.injector
3333
* @param {import('../../types').TaskExecutionApi} props.api
3434
* @param {boolean} props.isConnectionConfigured
35+
* @param {string} [props.configureConnectionBannerTitle]
36+
* @param {string} [props.configureConnectionBannerDescription]
37+
* @param {string} [props.configureConnectionLabel]
3538
* @param {Function} [props.onConfigureConnection]
3639
* @param {import('../../types').Config|undefined} [props.config]
3740
* @param {Function} [props.onConfigChanged=() => {}]
@@ -41,6 +44,9 @@ export default function TaskTesting({
4144
injector,
4245
api,
4346
isConnectionConfigured,
47+
configureConnectionBannerTitle = 'Connection required',
48+
configureConnectionBannerDescription = 'Configure a connection to start testing.',
49+
configureConnectionLabel = 'Configure',
4450
onConfigureConnection,
4551
config,
4652
onConfigChanged = () => {},
@@ -322,6 +328,9 @@ export default function TaskTesting({
322328
<div className="task-testing__container--right">
323329
<Output
324330
isConnectionConfigured={ isConnectionConfigured }
331+
configureConnectionBannerTitle={ configureConnectionBannerTitle }
332+
configureConnectionBannerDescription={ configureConnectionBannerDescription }
333+
configureConnectionLabel={ configureConnectionLabel }
325334
onConfigureConnection={ onConfigureConnection }
326335
isTaskExecuting={ isTaskExecuting }
327336
output={ output }

0 commit comments

Comments
 (0)