fix: fix types

Author: philippfromme

lib/components/TaskTesting/TaskTesting.js

@@ -34,6 +34,22 @@ import '../../style/style.scss';
 import { PluginContext, usePluginsProviderValue } from '../shared/plugins';
 import { OutputTab } from '../Output/OutputVariables';
 
+/**
+ * @param {import('../../types').TaskExecutionResult} result
+ * @returns {result is import('../../types').TaskExecutionIncidentResult}
+ */
+function isIncidentResult(result) {
+  return !result.success && result.reason === TASK_EXECUTION_REASON.INCIDENT;
+}
+
+/**
+ * @param {import('../../types').TaskExecutionResult} result
+ * @returns {result is import('../../types').TaskExecutionErrorResult}
+ */
+function isErrorResult(result) {
+  return !result.success && result.reason === TASK_EXECUTION_REASON.ERROR;
+}
+
 /**
  * @param {Object} props
  * @param {Object} props.injector
@@ -230,14 +246,14 @@ export default function TaskTesting({
           variables: result.variables,
           operateUrl: currentOperateUrl
         });
-      } else if (result.reason === TASK_EXECUTION_REASON.INCIDENT) {
+      } else if (isIncidentResult(result)) {
         elementConfigRef?.current?.setOutputConfigForElement(element, {
           success: false,
           variables: result.variables,
           incident: result.incident,
           operateUrl: currentOperateUrl
         });
-      } else if (result.reason === TASK_EXECUTION_REASON.ERROR) {
+      } else if (isErrorResult(result)) {
         elementConfigRef?.current?.setOutputConfigForElement(element, {
           success: false,
           error: result.error

lib/types.d.ts

@@ -81,32 +81,40 @@ export type TaskExecutionEvents =
   'taskExecution.status.changed' |
   'taskExecution.finished';
 
-export type TaskExecutionResult = 
-  // Success case - no reason needed
-  | {
-      success: true;
-      variables: ElementOutputVariables;
-    }
-  // Failure cases - always have reason
-  | {
-      success: false;
-      reason: typeof TASK_EXECUTION_REASON.INCIDENT;
-      incident: any;
-      variables?: ElementOutputVariables;
-    }
-  | {
-      success: false;
-      reason: typeof TASK_EXECUTION_REASON.USER_CANCEL;
-    }
-  | {
-      success: false;
-      reason: typeof TASK_EXECUTION_REASON.USER_SELECTION_CHANGED;
-    }
-  | {
-      success: false;
-      reason: typeof TASK_EXECUTION_REASON.ERROR;
-      error: TaskExecutionError;
-    };
+export type TaskExecutionSuccessResult = {
+  success: true;
+  variables: ElementOutputVariables;
+};
+
+export type TaskExecutionIncidentResult = {
+  success: false;
+  reason: typeof TASK_EXECUTION_REASON.INCIDENT;
+  incident: any;
+  variables?: ElementOutputVariables;
+};
+
+export type TaskExecutionUserCancelResult = {
+  success: false;
+  reason: typeof TASK_EXECUTION_REASON.USER_CANCEL;
+};
+
+export type TaskExecutionUserSelectionChangedResult = {
+  success: false;
+  reason: typeof TASK_EXECUTION_REASON.USER_SELECTION_CHANGED;
+};
+
+export type TaskExecutionErrorResult = {
+  success: false;
+  reason: typeof TASK_EXECUTION_REASON.ERROR;
+  error: TaskExecutionError;
+};
+
+export type TaskExecutionResult =
+  | TaskExecutionSuccessResult
+  | TaskExecutionIncidentResult
+  | TaskExecutionUserCancelResult
+  | TaskExecutionUserSelectionChangedResult
+  | TaskExecutionErrorResult;
 
 export type TaskExecutionError = {
   message: string;