fix: bump machines create timeout (#48)

Author: skatsaounis

.github/workflows/ci-test.yml

@@ -30,7 +30,7 @@ jobs:
           env -C "$GITHUB_WORKSPACE/$REPO_DIR" -- tox -e sanity
 
   units-test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3

plugins/module_utils/form.py

@@ -36,5 +36,5 @@ def get_mulipart(data):
             content += f'Content-Disposition: form-data; name="{k}"{rn}{rn}'
             content += str(v)
             content += rn
-        content += f"--{ boundary }--"
+        content += f"--{boundary}--"
         return boundary, content.encode("utf-8")

plugins/module_utils/machine.py

@@ -374,7 +374,9 @@ def commission(self, client):
 
     @classmethod
     def create(cls, client, payload):
-        maas_dict = client.post("/api/2.0/machines/", data=payload).json
+        maas_dict = client.post(
+            "/api/2.0/machines/", data=payload, timeout=60
+        ).json
         return cls.from_maas(maas_dict)
 
     def update(self, client, payload):

plugins/modules/dns_record.py

@@ -107,7 +107,7 @@ def get_match_or_fail(items, key, value, attribute_name):
 
     available_items = ", ".join(x[key] for x in items)
     raise errors.MaasError(
-        f"Can not find matching { attribute_name }. Options are [{ available_items }]"
+        f"Can not find matching {attribute_name}. Options are [{available_items}]"
     )
 
 

plugins/modules/subnet.py

@@ -147,7 +147,7 @@ def get_match_or_fail(items, key, value, attribute_name):
 
     available_items = ", ".join(x[key] for x in items)
     raise errors.MaasError(
-        f"Can not find matching { attribute_name }. Options are [{ available_items }]"
+        f"Can not find matching {attribute_name}. Options are [{available_items}]"
     )
 
 

plugins/modules/subnet_ip_range.py

@@ -128,7 +128,7 @@ def ensure_present(module, client: Client):
     if not subnet:
         available_subnets = ", ".join(x["name"] for x in subnets)
         raise errors.MaasError(
-            f"Can not find matching subnet. Options are [{ available_subnets }]"
+            f"Can not find matching subnet. Options are [{available_subnets}]"
         )
 
     compound_key = {

tests/integration/integration_config.yml.template

@@ -5,6 +5,7 @@ test_domain: ...
 token_key: ...
 token_secret: ...
 customer_key: ...
+test_distro_series: ...
 test_existing_vm_host: ...
 test_lxd_host:
   hostname: ...

tests/integration/targets/instance/tasks/main.yml

@@ -7,7 +7,6 @@
   vars:
     vm_host: "{% if test_existing_vm_host is defined %}{{ test_existing_vm_host }}{% else %}{{ test_lxd_host.hostname }}{% endif %}"
 
-
   block:
     - name: Delete machine
       maas.maas.instance: &delete
@@ -48,7 +47,7 @@
           - machine.record.memory == 8192
           - machine.record.cores == 4
           - machine.record.osystem == "ubuntu"
-          - machine.record.distro_series == "focal"
+          - machine.record.distro_series == "{{ test_distro_series }}"
           - machine.record.status == "Deployed"
 
     - name: Deploy machine - idempotence
@@ -62,7 +61,7 @@
           - machine.record.memory == 8192
           - machine.record.cores == 4
           - machine.record.osystem == "ubuntu"
-          - machine.record.distro_series == "focal"
+          - machine.record.distro_series == "{{ test_distro_series }}"
           - machine.record.status == "Deployed"
 
     - name: Release machine
@@ -147,7 +146,7 @@
     #       - machine.record.memory == 8192
     #       - machine.record.cores == 4
     #       - machine.record.osystem == "ubuntu"
-    #       - machine.record.distro_series == "focal"
+    #       - machine.record.distro_series == "{{ test_distro_series }}"
     #       - machine.record.status == "Deployed"
 
     # - name: Release machine (ephemeral machine is deleted)

tox.ini

@@ -93,7 +93,7 @@ commands =
     black --check {[base]lint_paths}
     flake8 {[base]lint_paths}
     ansible-lint
-    ansible-test sanity --local
+    ansible-test sanity --local --skip-test shebang
 
 [testenv:integration]
 passenv =