-
Notifications
You must be signed in to change notification settings - Fork 37
Expand file tree
/
Copy pathpam_test.go
More file actions
906 lines (759 loc) · 31.9 KB
/
pam_test.go
File metadata and controls
906 lines (759 loc) · 31.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
package pam_test
import (
"bytes"
"context"
"errors"
"fmt"
"io"
"net"
"os"
"os/user"
"path/filepath"
"strings"
"testing"
"time"
"github.com/canonical/authd/internal/brokers"
"github.com/canonical/authd/internal/brokers/auth"
"github.com/canonical/authd/internal/brokers/layouts"
"github.com/canonical/authd/internal/proto/authd"
"github.com/canonical/authd/internal/services/errmessages"
"github.com/canonical/authd/internal/services/pam"
"github.com/canonical/authd/internal/services/permissions"
"github.com/canonical/authd/internal/testutils"
"github.com/canonical/authd/internal/testutils/golden"
"github.com/canonical/authd/internal/users"
"github.com/canonical/authd/internal/users/db"
localgroupstestutils "github.com/canonical/authd/internal/users/localentries/testutils"
userslocking "github.com/canonical/authd/internal/users/locking"
userstestutils "github.com/canonical/authd/internal/users/testutils"
"github.com/canonical/authd/log"
"github.com/stretchr/testify/require"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
)
var (
globalBrokerManager *brokers.Manager
mockBrokerGeneratedID string
)
// Used for TestGetAuthenticationModes and TestSelectAuthenticationMode.
var (
requiredEntries = layouts.RequiredItems("entry_type", "other_entry_type")
optionalEntries = layouts.OptionalItems("entry_type", "other_entry_type")
optional = layouts.Optional
rendersQrCode = true
requiredEntry = &authd.UILayout{
Type: "required-entry",
Label: &optional,
Button: &optional,
Wait: &optional,
Entry: &requiredEntries,
Content: &optional,
Code: &optional,
RendersQrcode: &rendersQrCode,
}
optionalEntry = &authd.UILayout{
Type: "optional-entry",
Entry: &optionalEntries,
}
emptyType = &authd.UILayout{
Type: "",
Entry: &requiredEntries,
}
)
func TestNewService(t *testing.T) {
t.Parallel()
m, err := users.NewManager(users.DefaultConfig, t.TempDir())
require.NoError(t, err, "Setup: could not create user manager")
pm := permissions.New()
service := pam.NewService(context.Background(), m, globalBrokerManager, &pm)
brokers, err := service.AvailableBrokers(context.Background(), &authd.Empty{})
require.NoError(t, err, "can’t create the service directly")
require.NotEmpty(t, brokers.BrokersInfos, "Service is created and can query the broker manager")
}
func TestAvailableBrokers(t *testing.T) {
t.Parallel()
tests := map[string]struct {
currentUserNotRoot bool
wantErr bool
}{
"Success_getting_available_brokers": {},
"Error_when_not_root": {currentUserNotRoot: true, wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
pm := newPermissionManager(t, tc.currentUserNotRoot)
client := newPamClient(t, nil, globalBrokerManager, &pm)
abResp, err := client.AvailableBrokers(context.Background(), &authd.Empty{})
if tc.wantErr {
require.Error(t, err, "AvailableBrokers should return an error, but did not")
return
}
require.NoError(t, err, "AvailableBrokers should not return an error, but did")
got := abResp.GetBrokersInfos()
for _, broker := range got {
broker.Id = broker.Name + "_ID"
}
golden.CheckOrUpdateYAML(t, got)
})
}
}
func TestGetPreviousBroker(t *testing.T) {
t.Parallel()
// Get local user and get it set to local broker
u, err := user.Current()
require.NoError(t, err, "Setup: could not fetch current user")
currentUsername := u.Username
tests := map[string]struct {
user string
currentUserNotRoot bool
onlyLocalBroker bool
wantBroker string
wantErr bool
}{
"Success_getting_previous_broker": {user: "userwithbroker@example.com", wantBroker: mockBrokerGeneratedID},
"For_local_user,_get_local_broker": {user: currentUsername, wantBroker: brokers.LocalBrokerName},
"For_unmanaged_user_and_only_one_broker,_get_local_broker": {user: "nonexistent@example.com", onlyLocalBroker: true, wantBroker: brokers.LocalBrokerName},
"Username_is_case_insensitive": {user: "UserWithBroker@example.com", wantBroker: mockBrokerGeneratedID},
"Returns_empty_when_user_does_not_exist": {user: "nonexistent@example.com", wantBroker: ""},
"Returns_empty_when_user_does_not_have_a_broker": {user: "userwithoutbroker@example.com", wantBroker: ""},
"Returns_empty_when_broker_is_not_available": {user: "userwithinactivebroker@example.com", wantBroker: ""},
"Error_when_not_root": {user: "userwithbroker@example.com", currentUserNotRoot: true, wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
dbDir := t.TempDir()
// We have to replace MOCKBROKERID with our generated broker id.
f, err := os.Open(filepath.Join(testutils.TestFamilyPath(t), "get-previous-broker.db"))
require.NoError(t, err, "Setup: could not open fixture database file")
defer f.Close()
d, err := io.ReadAll(f)
require.NoError(t, err, "Setup: could not read fixture database file")
d = bytes.ReplaceAll(d, []byte("MOCKBROKERID"), []byte(mockBrokerGeneratedID))
err = db.Z_ForTests_CreateDBFromYAMLReader(bytes.NewBuffer(d), dbDir)
require.NoError(t, err, "Setup: could not create database from testdata")
m, err := users.NewManager(users.DefaultConfig, dbDir)
require.NoError(t, err, "Setup: could not create user manager")
t.Cleanup(func() { _ = m.Stop() })
pm := newPermissionManager(t, tc.currentUserNotRoot)
brokerManager := globalBrokerManager
if tc.onlyLocalBroker {
brokerManager, err = brokers.NewManager(context.Background(), "", nil)
require.NoError(t, err, "Setup: could not create broker manager with only local broker")
}
client := newPamClient(t, m, brokerManager, &pm)
// Get existing entry
gotResp, err := client.GetPreviousBroker(context.Background(), &authd.GPBRequest{Username: tc.user})
if tc.wantErr {
require.Error(t, err, "GetPreviousBroker should return an error, but did not")
return
}
require.NoError(t, err, "GetPreviousBroker should not return an error, but did")
require.Equal(t, tc.wantBroker, gotResp.GetPreviousBroker(), "GetPreviousBroker should return expected broker")
})
}
}
func TestSelectBroker(t *testing.T) {
t.Parallel()
tests := map[string]struct {
brokerID string
username string
sessionMode string
existingDB string
currentUserNotRoot bool
wantErr bool
}{
"Successfully_select_a_broker_and_creates_auth_session": {username: "success@example.com", sessionMode: auth.SessionModeLogin},
"Successfully_select_a_broker_and_creates_passwd_session": {username: "success@example.com", sessionMode: auth.SessionModeChangePassword},
"Error_when_not_root": {username: "success@example.com", currentUserNotRoot: true, wantErr: true},
"Error_when_username_is_empty": {wantErr: true},
"Error_when_mode_is_empty": {sessionMode: "-", wantErr: true},
"Error_when_mode_does_not_exist": {sessionMode: "does not exist", wantErr: true},
"Error_when_brokerID_is_empty": {username: "empty broker@example.com", brokerID: "-", wantErr: true},
"Error_when_broker_does_not_exist": {username: "no broker@example.com", brokerID: "does not exist", wantErr: true},
"Error_when_broker_does_not_provide_a_session_ID": {username: "ns_no_id@example.com", wantErr: true},
"Error_when_starting_the_session": {username: "ns_error@example.com", wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
cacheDir := t.TempDir()
if tc.existingDB != "" {
err := db.Z_ForTests_CreateDBFromYAML(filepath.Join(testutils.TestFamilyPath(t), tc.existingDB), cacheDir)
require.NoError(t, err, "Setup: could not create database from testdata")
}
m, err := users.NewManager(users.DefaultConfig, cacheDir)
require.NoError(t, err, "Setup: could not create user manager")
t.Cleanup(func() { _ = m.Stop() })
pm := newPermissionManager(t, tc.currentUserNotRoot)
client := newPamClient(t, m, globalBrokerManager, &pm)
switch tc.brokerID {
case "":
tc.brokerID = mockBrokerGeneratedID
case "-":
tc.brokerID = ""
}
if tc.username != "" {
tc.username = t.Name() + testutils.IDSeparator + tc.username
}
var sessionMode authd.SessionMode
switch tc.sessionMode {
case auth.SessionModeLogin, "":
sessionMode = authd.SessionMode_LOGIN
case auth.SessionModeChangePassword:
sessionMode = authd.SessionMode_CHANGE_PASSWORD
case "-":
sessionMode = authd.SessionMode_UNDEFINED
}
sbRequest := &authd.SBRequest{
BrokerId: tc.brokerID,
Username: tc.username,
Mode: sessionMode,
}
sbResp, err := client.SelectBroker(context.Background(), sbRequest)
if tc.wantErr {
require.Error(t, err, "SelectBroker should return an error, but did not")
return
}
require.NoError(t, err, "SelectBroker should not return an error, but did")
got := fmt.Sprintf("ID: %s\nEncryption Key: %s\n",
strings.ReplaceAll(sbResp.GetSessionId(), tc.brokerID, "BROKER_ID"),
sbResp.GetEncryptionKey())
golden.CheckOrUpdate(t, got)
})
}
}
func TestGetAuthenticationModes(t *testing.T) {
t.Parallel()
tests := map[string]struct {
sessionID string
supportedUILayouts []*authd.UILayout
username string
currentUserNotRoot bool
wantErr bool
}{
"Successfully_get_authentication_modes": {},
"Successfully_get_multiple_authentication_modes": {username: "gam_multiple_modes@example.com"},
"Error_when_not_root": {currentUserNotRoot: true, wantErr: true},
"Error_when_sessionID_is_empty": {sessionID: "-", wantErr: true},
"Error_when_passing_invalid_layout": {supportedUILayouts: []*authd.UILayout{emptyType}, wantErr: true},
"Error_when_sessionID_is_invalid": {sessionID: "invalid-session", wantErr: true},
"Error_when_getting_authentication_modes": {username: "gam_error@example.com", wantErr: true},
"Error_when_broker_returns_invalid_modes": {username: "gam_invalid@example.com", wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
pm := newPermissionManager(t, false) // Allow starting the session (current user considered root)
client := newPamClient(t, nil, globalBrokerManager, &pm)
switch tc.sessionID {
case "invalid-session":
case "-":
tc.sessionID = ""
default:
id := startSession(t, client, tc.username)
if tc.sessionID == "" {
tc.sessionID = id
}
}
// Now, set tests permissions for this use case
permissions.Z_ForTests_SetCurrentUserAsRoot(&pm, !tc.currentUserNotRoot)
if tc.supportedUILayouts == nil {
tc.supportedUILayouts = []*authd.UILayout{requiredEntry}
}
gamReq := &authd.GAMRequest{
SessionId: tc.sessionID,
SupportedUiLayouts: tc.supportedUILayouts,
}
gamResp, err := client.GetAuthenticationModes(context.Background(), gamReq)
if tc.wantErr {
require.Error(t, err, "GetAuthenticationModes should return an error, but did not")
return
}
require.NoError(t, err, "GetAuthenticationModes should not return an error, but did")
got := gamResp.GetAuthenticationModes()
golden.CheckOrUpdateYAML(t, got)
})
}
}
func TestSelectAuthenticationMode(t *testing.T) {
t.Parallel()
tests := map[string]struct {
sessionID string
authMode string
username string
supportedUILayouts []*authd.UILayout
noValidators bool
currentUserNotRoot bool
wantErr bool
}{
"Successfully_select_mode_with_required_value": {username: "sam_success_required_entry@example.com", supportedUILayouts: []*authd.UILayout{requiredEntry}},
"Successfully_select_mode_with_missing_optional_value": {username: "sam_missing_optional_entry@example.com", supportedUILayouts: []*authd.UILayout{optionalEntry}},
// service errors
"Error_when_not_root": {username: "sam_success_required_entry@example.com", currentUserNotRoot: true, wantErr: true},
"Error_when_sessionID_is_empty": {sessionID: "-", wantErr: true},
"Error_when_session_ID_is_invalid": {sessionID: "invalid-session", wantErr: true},
"Error_when_no_authmode_is_selected": {sessionID: "no auth mode", authMode: "-", wantErr: true},
// broker errors
"Error_when_selecting_invalid_auth_mode": {username: "sam_error@example.com", supportedUILayouts: []*authd.UILayout{requiredEntry}, wantErr: true},
"Error_when_broker_does_not_have_validators_for_the_session": {username: "does not matter@example.com", noValidators: true, wantErr: true},
/* Layout errors */
"Error_when_returns_no_layout": {username: "sam_no_layout@example.com", supportedUILayouts: []*authd.UILayout{requiredEntry}, wantErr: true},
"Error_when_returns_layout_with_no_type": {username: "sam_no_layout_type@example.com", supportedUILayouts: []*authd.UILayout{requiredEntry}, wantErr: true},
"Error_when_returns_layout_without_required_value": {username: "sam_missing_required_entry@example.com", supportedUILayouts: []*authd.UILayout{requiredEntry}, wantErr: true},
"Error_when_returns_layout_with_unknown_field": {username: "sam_unknown_field@example.com", supportedUILayouts: []*authd.UILayout{requiredEntry}, wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
pm := newPermissionManager(t, false) // Allow starting the session (current user considered root)
client := newPamClient(t, nil, globalBrokerManager, &pm)
switch tc.sessionID {
case "invalid-session":
case "-":
tc.sessionID = ""
default:
id := startSession(t, client, tc.username)
if tc.sessionID == "" {
tc.sessionID = id
}
}
switch tc.authMode {
case "":
tc.authMode = "some mode"
case "-":
tc.authMode = ""
}
// If the username does not have a sam_something, it means we don't care about the broker answer and we don't need the validators.
if !tc.noValidators && strings.HasPrefix(tc.username, "sam_") {
// We need to call GetAuthenticationModes to generate the layout validators on the broker.
gamReq := &authd.GAMRequest{
SessionId: tc.sessionID,
SupportedUiLayouts: tc.supportedUILayouts,
}
_, err := client.GetAuthenticationModes(context.Background(), gamReq)
require.NoError(t, err, "Setup: failed to get authentication modes for tests")
}
// Now, set tests permissions for this use case
permissions.Z_ForTests_SetCurrentUserAsRoot(&pm, !tc.currentUserNotRoot)
samReq := &authd.SAMRequest{
SessionId: tc.sessionID,
AuthenticationModeId: tc.authMode,
}
samResp, err := client.SelectAuthenticationMode(context.Background(), samReq)
if tc.wantErr {
require.Error(t, err, "SelectAuthenticationMode should return an error, but did not")
return
}
require.NoError(t, err, "SelectAuthenticationMode should not return an error, but did")
got := samResp.GetUiLayoutInfo()
golden.CheckOrUpdateYAML(t, got)
})
}
}
func TestIsAuthenticated(t *testing.T) {
tests := map[string]struct {
sessionID string
existingDB string
username string
secondCall bool
cancelFirstCall bool
localGroupsFile string
currentUserNotRoot bool
// There is no wantErr as it's stored in the golden file.
}{
"Successfully_authenticate": {username: "success@example.com"},
"Successfully_authenticate_if_first_call_is_canceled": {username: "ia_second_call@example.com", secondCall: true, cancelFirstCall: true},
"Denies_authentication_when_broker_times_out": {username: "ia_timeout@example.com"},
"Update_existing_DB_on_success": {username: "success@example.com", existingDB: "cache-with-user.db"},
"Update_local_groups": {username: "success_with_local_groups@example.com", localGroupsFile: "valid.group"},
"Successfully_authenticate_user_with_uppercase": {username: "SUCCESS@example.com"},
"Successfully_authenticate_with_groups_with_uppercase": {username: "success_with_uppercase_groups@example.com"},
// service errors
"Error_when_not_root": {username: "success@example.com", currentUserNotRoot: true},
"Error_when_sessionID_is_empty": {sessionID: "-"},
"Error_when_there_is_no_broker": {sessionID: "invalid-session"},
"Error_when_user_is_locked": {username: "locked@example.com", existingDB: "cache-with-locked-user.db"},
// broker errors
"Error_when_authenticating": {username: "ia_error@example.com"},
"Error_on_empty_data_even_if_granted": {username: "ia_empty_data@example.com"},
"Error_when_broker_returns_invalid_access": {username: "ia_invalid_access@example.com"},
"Error_when_broker_returns_invalid_data": {username: "ia_invalid_data@example.com"},
"Error_when_broker_returns_invalid_userinfo": {username: "ia_invalid_userinfo@example.com"},
"Error_when_broker_returns_invalid_username": {username: "ia_info_invalid_username@example.com"},
"Error_when_calling_second_time_without_cancelling": {username: "ia_second_call@example.com", secondCall: true},
// local group error
"Error_on_updating_local_groups_with_unexisting_file": {username: "success_with_local_groups@example.com", localGroupsFile: "does_not_exists.group"},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
if tc.localGroupsFile == "" {
t.Parallel()
}
var destGroupFile string
if tc.localGroupsFile != "" {
destGroupFile = localgroupstestutils.SetupGroupMock(t,
filepath.Join(testutils.TestFamilyPath(t), tc.localGroupsFile))
}
dbDir := t.TempDir()
if tc.existingDB != "" {
err := db.Z_ForTests_CreateDBFromYAML(filepath.Join(testutils.TestFamilyPath(t), tc.existingDB), dbDir)
require.NoError(t, err, "Setup: could not create database from testdata")
}
managerOpts := []users.Option{
users.WithIDGenerator(&users.IDGeneratorMock{
UIDsToGenerate: []uint32{1111},
GIDsToGenerate: []uint32{22222, 33333, 44444},
}),
}
m, err := users.NewManager(users.DefaultConfig, dbDir, managerOpts...)
require.NoError(t, err, "Setup: could not create user manager")
t.Cleanup(func() { _ = m.Stop() })
pm := newPermissionManager(t, false) // Allow starting the session (current user considered root)
client := newPamClient(t, m, globalBrokerManager, &pm)
switch tc.sessionID {
case "invalid-session":
case "-":
tc.sessionID = ""
default:
id := startSession(t, client, tc.username)
if tc.sessionID == "" {
tc.sessionID = id
}
}
// Now, set tests permissions for this use case
permissions.Z_ForTests_SetCurrentUserAsRoot(&pm, !tc.currentUserNotRoot)
var firstCall, secondCall string
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
done := make(chan struct{})
go func() {
defer close(done)
iaReq := &authd.IARequest{
SessionId: tc.sessionID,
AuthenticationData: &authd.IARequest_AuthenticationData{},
}
iaResp, err := client.IsAuthenticated(ctx, iaReq)
firstCall = fmt.Sprintf("FIRST CALL:\n\taccess: %s\n\tmsg: %s\n\terr: %v\n",
iaResp.GetAccess(),
iaResp.GetMsg(),
err,
)
}()
// Give some time for the first call to block
time.Sleep(time.Second)
if tc.cancelFirstCall {
cancel()
time.Sleep(500 * time.Millisecond)
<-done
}
if tc.secondCall {
iaReq := &authd.IARequest{
SessionId: tc.sessionID,
AuthenticationData: &authd.IARequest_AuthenticationData{},
}
iaResp, err := client.IsAuthenticated(context.Background(), iaReq)
secondCall = fmt.Sprintf("SECOND CALL:\n\taccess: %s\n\tmsg: %s\n\terr: %v\n",
iaResp.GetAccess(),
iaResp.GetMsg(),
err,
)
}
<-done
got := firstCall + secondCall
got = permissions.Z_ForTests_IdempotentPermissionError(got)
golden.CheckOrUpdate(t, got, golden.WithPath("IsAuthenticated"))
// Check that all usernames in the database are lowercase
allUsers, err := m.AllUsers()
require.NoError(t, err, "Setup: failed to get users from manager")
for _, u := range allUsers {
require.Equal(t, strings.ToLower(u.Name), u.Name, "all usernames in the database should be lowercase")
}
// Check that all groups in the database are lowercase
groups, err := m.AllGroups()
require.NoError(t, err, "Setup: failed to get groups from manager")
for _, group := range groups {
require.Equal(t, strings.ToLower(group.Name), group.Name, "all groups in the database should be lowercase")
}
// Check that database has been updated too.
gotDB, err := db.Z_ForTests_DumpNormalizedYAML(userstestutils.DBManager(m))
require.NoError(t, err, "Setup: failed to dump database for comparing")
golden.CheckOrUpdate(t, gotDB, golden.WithPath("cache.db"))
localgroupstestutils.RequireGroupFile(t, destGroupFile, golden.Path(t))
})
}
}
func TestIDGeneration(t *testing.T) {
t.Parallel()
usernamePrefix := t.Name()
tests := map[string]struct {
username string
}{
"Generate_ID": {username: "success@example.com"},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
managerOpts := []users.Option{
users.WithIDGenerator(&users.IDGeneratorMock{
UIDsToGenerate: []uint32{1111},
GIDsToGenerate: []uint32{22222},
}),
}
m, err := users.NewManager(users.DefaultConfig, t.TempDir(), managerOpts...)
require.NoError(t, err, "Setup: could not create user manager")
t.Cleanup(func() { _ = m.Stop() })
pm := newPermissionManager(t, false) // Allow starting the session (current user considered root)
client := newPamClient(t, m, globalBrokerManager, &pm)
sbResp, err := client.SelectBroker(context.Background(), &authd.SBRequest{
BrokerId: mockBrokerGeneratedID,
Username: usernamePrefix + testutils.IDSeparator + tc.username,
Mode: authd.SessionMode_LOGIN,
})
require.NoError(t, err, "Setup: failed to create session for tests")
resp, err := client.IsAuthenticated(context.Background(), &authd.IARequest{SessionId: sbResp.GetSessionId()})
require.NoError(t, err, "Setup: could not authenticate user")
require.Equal(t, "granted", resp.GetAccess(), "Setup: authentication should be granted")
gotDB, err := db.Z_ForTests_DumpNormalizedYAML(userstestutils.DBManager(m))
require.NoError(t, err, "Setup: failed to dump database for comparing")
golden.CheckOrUpdate(t, gotDB, golden.WithPath("cache.db"))
})
}
}
func TestSetDefaultBrokerForUser(t *testing.T) {
t.Parallel()
tests := map[string]struct {
username string
brokerID string
currentUserNotRoot bool
wantErr bool
}{
"Set_default_broker_for_existing_user_with_no_broker": {username: "usersetbroker@example.com"},
"Update_default_broker_for_existing_user_with_a_broker": {username: "userupdatebroker@example.com"},
"Username_is_case_insensitive": {username: "UserSetBroker@example.com"},
"Error_when_setting_default_broker_to_local_broker": {username: "userlocalbroker@example.com", brokerID: brokers.LocalBrokerName, wantErr: true},
"Error_when_not_root": {username: "usersetbroker@example.com", currentUserNotRoot: true, wantErr: true},
"Error_when_username_is_empty": {wantErr: true},
"Error_when_user_does_not_exist_": {username: "doesnotexist@example.com", wantErr: true},
"Error_when_broker_does_not_exist": {username: "userwithbroker@example.com", brokerID: "does not exist", wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
dbDir := t.TempDir()
err := db.Z_ForTests_CreateDBFromYAML(filepath.Join(testutils.TestFamilyPath(t), "set-default-broker.db"), dbDir)
require.NoError(t, err, "Setup: could not create database from testdata")
m, err := users.NewManager(users.DefaultConfig, dbDir)
require.NoError(t, err, "Setup: could not create user manager")
t.Cleanup(func() { _ = m.Stop() })
pm := newPermissionManager(t, tc.currentUserNotRoot)
client := newPamClient(t, m, globalBrokerManager, &pm)
if tc.brokerID == "" {
tc.brokerID = mockBrokerGeneratedID
}
sdbfuReq := &authd.SDBFURequest{
BrokerId: tc.brokerID,
Username: tc.username,
}
_, err = client.SetDefaultBrokerForUser(context.Background(), sdbfuReq)
if tc.wantErr {
require.Error(t, err, "SetDefaultBrokerForUser should return an error, but did not")
return
}
require.NoError(t, err, "SetDefaultBrokerForUser should not return an error, but did")
gpbResp, err := client.GetPreviousBroker(context.Background(), &authd.GPBRequest{Username: tc.username})
require.NoError(t, err, "GetPreviousBroker should not return an error")
require.Equal(t, tc.brokerID, gpbResp.GetPreviousBroker(), "SetDefaultBrokerForUser should set the default broker as expected")
// Check that database has been updated too.
gotDB, err := db.Z_ForTests_DumpNormalizedYAML(userstestutils.DBManager(m))
require.NoError(t, err, "Setup: failed to dump database for comparing")
golden.CheckOrUpdate(t, gotDB, golden.WithPath("cache.db"))
})
}
}
func TestEndSession(t *testing.T) {
t.Parallel()
tests := map[string]struct {
sessionID string
username string
currentUserNotRoot bool
wantErr bool
}{
"Successfully_end_session": {username: "success@example.com"},
"Error_when_not_root": {username: "success@example.com", currentUserNotRoot: true, wantErr: true},
"Error_when_sessionID_is_empty": {sessionID: "-", wantErr: true},
"Error_when_sessionID_is_invalid": {sessionID: "invalid-session", wantErr: true},
"Error_when_ending_session": {username: "es_error@example.com", wantErr: true},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
pm := newPermissionManager(t, false) // Allow starting the session (current user considered root)
client := newPamClient(t, nil, globalBrokerManager, &pm)
switch tc.sessionID {
case "invalid-session":
case "-":
tc.sessionID = ""
default:
id := startSession(t, client, tc.username)
if tc.sessionID == "" {
tc.sessionID = id
}
}
// Now, set tests permissions for this use case
permissions.Z_ForTests_SetCurrentUserAsRoot(&pm, !tc.currentUserNotRoot)
esReq := &authd.ESRequest{
SessionId: tc.sessionID,
}
_, err := client.EndSession(context.Background(), esReq)
if tc.wantErr {
require.Error(t, err, "EndSession should return an error, but did not")
return
}
require.NoError(t, err, "EndSession should not return an error, but did")
})
}
}
// initBrokers starts dbus mock brokers on the system bus. It returns its config path.
func initBrokers() (brokerConfigPath string, cleanup func(), err error) {
tmpDir, err := os.MkdirTemp("", "authd-internal-pam-tests-")
if err != nil {
return "", nil, err
}
brokersConfPath := filepath.Join(tmpDir, "etc", "authd", "broker.d")
if err = os.MkdirAll(brokersConfPath, 0750); err != nil {
_ = os.RemoveAll(tmpDir)
return "", nil, err
}
_, brokerCleanup, err := testutils.StartBusBrokerMock(brokersConfPath, "BrokerMock")
if err != nil {
_ = os.RemoveAll(tmpDir)
return "", nil, err
}
return brokersConfPath, func() {
brokerCleanup()
_ = os.RemoveAll(tmpDir)
}, nil
}
// newPAMClient returns a new GRPC PAM client for tests connected to brokerManager with the given database and
// permissionmanager.
// If the one passed is nil, this function will create the database and close it upon test teardown.
func newPamClient(t *testing.T, m *users.Manager, brokerManager *brokers.Manager, pm *permissions.Manager) (client authd.PAMClient) {
t.Helper()
// socket path is limited in length.
tmpDir, err := os.MkdirTemp("", "authd-socket-dir")
require.NoError(t, err, "Setup: could not setup temporary socket dir path")
t.Cleanup(func() { _ = os.RemoveAll(tmpDir) })
socketPath := filepath.Join(tmpDir, "authd.sock")
lis, err := net.Listen("unix", socketPath)
require.NoError(t, err, "Setup: could not create unix socket")
if m == nil {
m, err = users.NewManager(users.DefaultConfig, t.TempDir())
require.NoError(t, err, "Setup: could not create user manager")
t.Cleanup(func() { _ = m.Stop() })
}
service := pam.NewService(context.Background(), m, brokerManager, pm)
grpcServer := grpc.NewServer(permissions.WithUnixPeerCreds(), grpc.ChainUnaryInterceptor(enableCheckGlobalAccess(service), errmessages.RedactErrorInterceptor))
authd.RegisterPAMServer(grpcServer, service)
done := make(chan struct{})
go func() {
defer close(done)
_ = grpcServer.Serve(lis)
}()
t.Cleanup(func() {
grpcServer.Stop()
<-done
})
conn, err := grpc.NewClient("unix://"+socketPath, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithUnaryInterceptor(errmessages.FormatErrorMessage))
require.NoError(t, err, "Setup: Could not connect to gRPC server")
t.Cleanup(func() { _ = conn.Close() }) // We don't care about the error on cleanup
return authd.NewPAMClient(conn)
}
// newPermissionManager factors out permission manager creation for tests.
// this permission manager can then be tweaked for mimicking currentUser considered as root not.
func newPermissionManager(t *testing.T, currentUserNotRoot bool) permissions.Manager {
t.Helper()
var opts = []permissions.Option{}
if !currentUserNotRoot {
opts = append(opts, permissions.Z_ForTests_WithCurrentUserAsRoot())
}
return permissions.New(opts...)
}
// enableCheckGlobalAccess returns the middleware hooking up in CheckGlobalAccess for the given service.
func enableCheckGlobalAccess(s pam.Service) grpc.UnaryServerInterceptor {
return func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
if err := s.CheckGlobalAccess(ctx, info.FullMethod); err != nil {
return nil, err
}
return handler(ctx, req)
}
}
// getMockBrokerGeneratedID returns the generated ID for the mock broker.
func getMockBrokerGeneratedID(brokerManager *brokers.Manager) (string, error) {
for _, b := range brokerManager.AvailableBrokers() {
if b.Name != "BrokerMock" {
continue
}
return b.ID, nil
}
return "", errors.New("Setup: could not find generated broker mock ID in the broker manager list")
}
// startSession is a helper that starts a session on the mock broker.
func startSession(t *testing.T, client authd.PAMClient, username string) string {
t.Helper()
if username == "" {
username = "user@example.com"
}
// Prefixes the username to avoid concurrency issues.
username = t.Name() + testutils.IDSeparator + username
sbResp, err := client.SelectBroker(context.Background(), &authd.SBRequest{
BrokerId: mockBrokerGeneratedID,
Username: username,
Mode: authd.SessionMode_LOGIN,
})
require.NoError(t, err, "Setup: failed to create session for tests")
return sbResp.GetSessionId()
}
// setupGlobalBrokerMock creates and points to a test-wide system bus, registering the mock broker on it.
func setupGlobalBrokerMock() (cleanup func(), err error) {
cleanup = func() {}
// Start system bus mock.
busCleanup, err := testutils.StartSystemBusMock()
if err != nil {
return cleanup, err
}
cleanup = busCleanup
// Start brokers mock over dbus.
brokersConfPath, brokerCleanup, err := initBrokers()
if err != nil {
return cleanup, err
}
cleanup = func() {
brokerCleanup()
busCleanup()
}
// Get manager shared across grpc services.
globalBrokerManager, err = brokers.NewManager(context.Background(), brokersConfPath, nil)
if err != nil {
return cleanup, err
}
mockBrokerGeneratedID, err = getMockBrokerGeneratedID(globalBrokerManager)
if err != nil {
return cleanup, err
}
return cleanup, nil
}
func TestMain(m *testing.M) {
log.SetLevel(log.DebugLevel)
userslocking.Z_ForTests_OverrideLocking()
defer userslocking.Z_ForTests_RestoreLocking()
cleanup, err := setupGlobalBrokerMock()
if err != nil {
cleanup()
fmt.Fprintf(os.Stderr, "%v\n", err)
os.Exit(1)
}
defer cleanup()
m.Run()
}