next statement not handled

Author: p-gentili

checkbox-support/checkbox_support/helpers/audio_server_utils.py

@@ -321,17 +321,24 @@ def match(node_id: str, node_name: str, obj) -> bool:
             # handle cases where the node name include an index
             # i.e. alsa_output.pci-0000_00_1f.3.analog-stereo.10
             stripped_name = node.name.rsplit(".", 1)[0]
-            new_node = next(
-                obj
-                for obj in nodes.values()
-                if obj.get("info", {})
-                .get("props", {})
-                .get("node.name", "")
-                .rsplit(".", 1)[0]
-                == stripped_name
-            )
-            node.id = str(new_node["info"]["props"]["node.id"])
-            node.name = new_node["info"]["props"]["node.name"]
+            try:
+                new_node = next(
+                    obj
+                    for obj in nodes.values()
+                    if obj.get("info", {})
+                    .get("props", {})
+                    .get("node.name", "")
+                    .rsplit(".", 1)[0]
+                    == stripped_name
+                )
+                node.id = str(new_node["info"]["props"]["node.id"])
+                node.name = new_node["info"]["props"]["node.name"]
+            except StopIteration:
+                raise RuntimeError(
+                    "Node '{}' (id: {}) not found after setting profile '{}' on device '{}'".format(
+                        node.name, node.id, node.profile_id, node.device_id
+                    )
+                )
 
         self._set_default_audio_node(node.id)
 

checkbox-support/checkbox_support/helpers/tests/test_audio_server_utils.py

@@ -353,6 +353,20 @@ def test_set_node_of_type_ephemeral(self):
         self.pipewire._set_card_profile.assert_called_once_with("1", "2")
         self.pipewire._set_default_audio_node.assert_called_once_with("new_id")
 
+    def test_set_node_of_type_not_found(self):
+        """Test setting a node that cannot be found raises RuntimeError."""
+
+        node = Node("1", "2", "name", "id", "description")
+        self.pipewire._set_card_profile = Mock()
+        self.pipewire._get_audio_nodes = Mock(return_value={})
+
+        with self.assertRaises(RuntimeError) as cm:
+            self.pipewire._set_node_of_type(node, NodeType.SINK)
+
+        self.assertIn("name", str(cm.exception))
+        self.assertIn("id", str(cm.exception))
+        self.assertIn("not found", str(cm.exception))
+
 
 class PulseaudioUtilsTests(unittest.TestCase):
     """Test cases for the PulseaudioUtils class."""