Go through bios_data keys in a deterministic way

pieqq · pieqq · commit 6b8a45aaa71e · 2026-03-22T21:54:50.000+01:00
This is to prevent a bug in python3.5 when running the unit tests, since
dictionaries are unordered.
diff --git a/checkbox-ng/checkbox_ng/support/device_info.py b/checkbox-ng/checkbox_ng/support/device_info.py
@@ -54,7 +54,7 @@ def get_bios_info() -> dict:
     }
     bios_root = Path("/sys/class/dmi/id/")
     bios_data_name = "bios_{}"
-    for key in bios_data:
+    for key in sorted(bios_data.keys()):
         try:
             value = (
                 (bios_root / bios_data_name.format(key)).read_text().strip()

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ def get_bios_info() -> dict:`
`54`	`54`	`}`
`55`	`55`	`bios_root = Path("/sys/class/dmi/id/")`
`56`	`56`	`bios_data_name = "bios_{}"`
`57`		`- for key in bios_data:`
	`57`	`+ for key in sorted(bios_data.keys()):`
`58`	`58`	`try:`
`59`	`59`	`value = (`
`60`	`60`	`(bios_root / bios_data_name.format(key)).read_text().strip()`