Skip to content

Commit 8de233b

Browse files
Apply suggestions from code review
Co-authored-by: stanley31huang <stanley.huang@canonical.com>
1 parent 54bc37e commit 8de233b

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/serial_test.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ class Serial:
5757
def __init__(
5858
self,
5959
node,
60-
type=None,
61-
group=None,
62-
baudrate=None,
63-
bytesize=None,
64-
parity=None,
65-
stopbits=None,
66-
timeout=None,
67-
data_size=None,
68-
rs485_settings=None,
60+
type: str | None = None,
61+
group: list | None = None,
62+
baudrate: int | None = None,
63+
bytesize: int | None = None,
64+
parity: int | None = None,
65+
stopbits: int | None = None,
66+
timeout: int | None = None,
67+
data_size: int | None = None,
68+
rs485_settings: dict | None = None,
6969
) -> None:
7070
self.node = node
7171
self.type = type if type else "USB"
@@ -315,7 +315,6 @@ def create_args():
315315
help="Baud rate for the serial ports",
316316
default=115200,
317317
type=int,
318-
required=False,
319318
)
320319
parser.add_argument(
321320
"--bytesize",

0 commit comments

Comments
 (0)