Skip to content

Commit de25441

Browse files
committed
Clarify skip_reason in result.py
1 parent 8e6f1da commit de25441

1 file changed

Lines changed: 17 additions & 6 deletions

File tree

checkbox-ng/plainbox/impl/result.py

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ class JobResultBuilder(pod.POD):
287287
assign_filter_list=[pod.unset_or_typed],
288288
)
289289
skip_reason = pod.Field(
290-
"list of inhibitors (reasons why a job could not start)",
290+
"dict of inhibitors (reasons why a job could not start)",
291291
dict,
292292
pod.UNSET,
293293
assign_filter_list=[pod.unset_or_typed],
@@ -559,12 +559,23 @@ def is_hollow(self):
559559
@property
560560
def skip_reason(self):
561561
"""
562-
Get the skip_reason list that explains why a job could not start.
562+
Dictionary that explains why a job could not start.
563563
564-
This is a list of inhibitor dicts with keys like:
565-
- related_dependencies: list of job ids
566-
- related_resources: list of resource expressions
567-
- related_manifests: list of manifest expressions
564+
This is a dict of inhibitor lists that looks like this:
565+
566+
{
567+
'related_dependencies': ['com.canonical.certification::smoke/false'],
568+
'related_manifests': ["manifest.doesnt_exist == 'True'"],
569+
'related_resources': []
570+
}
571+
572+
or
573+
574+
{
575+
'related_dependencies': [],
576+
'related_manifests': [],
577+
'related_resources': ['package.name == "missing-program"']
578+
}
568579
"""
569580
return self._data.get("skip_reason")
570581

0 commit comments

Comments
 (0)