Skip to content

Commit e647807

Browse files
exporters:html: fix I/O log links when not-supported jobs exist (BugFix) (#2443)
exporters:html: Fix I/O log anchor mismatch with not-supported jobs (BugFix) The I/O log page generation loop was missing the 'not-supported' outcome filter that was already applied to the table display loop. This caused loop.index to diverge when a not-supported job appeared alphabetically before a pass/fail job in the same category, linking the wrong I/O log. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 218659c commit e647807

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

checkbox-ng/plainbox/impl/providers/exporters/data/checkbox.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ <h1>Debian Packages</h1>
372372
{%- endif %}
373373
{%- for cat_id, cat_name in category_map|dictsort(false, 'value') %}
374374
{% set mainloop = loop %}
375-
{%- for job_id, job_state in job_state_map|dictsort if job_state.result.outcome != None and job_state.effective_category_id == cat_id and job_state.job.plugin not in ("resource", "attachment") %}
375+
{%- for job_id, job_state in job_state_map|dictsort if job_state.result.outcome != None and job_state.result.outcome != 'not-supported' and job_state.effective_category_id == cat_id and job_state.job.plugin not in ("resource", "attachment") %}
376376
{%- if job_state.result.io_log_as_flat_text != "" %}
377377
<div class="jqm-demos ui-page" tabindex="0" data-url="{{ mainloop.index }}-{{ loop.index }}" id="{{ mainloop.index }}-{{ loop.index }}-log" data-role="page">
378378
<div data-role="header" class="jqm-header">

checkbox-ng/plainbox/impl/providers/exporters/data/multi-page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ <h1>Debian Packages</h1>
424424

425425
{%- for cat_id, cat_name in category_map|dictsort(false, 'value') %}
426426
{% set mainloop = loop %}
427-
{%- for job_id, job_state in job_state_map|dictsort if job_state.result.outcome != None and job_state.effective_category_id == cat_id and job_state.job.plugin not in ("resource", "attachment") %}
427+
{%- for job_id, job_state in job_state_map|dictsort if job_state.result.outcome != None and job_state.result.outcome != 'not-supported' and job_state.effective_category_id == cat_id and job_state.job.plugin not in ("resource", "attachment") %}
428428
{%- if job_state.result.io_log_as_flat_text != "" %}
429429
<div class="jqm-demos ui-page" tabindex="0" data-url="{{ managerloop.index }}-{{ mainloop.index }}-{{ loop.index }}" id="{{ managerloop.index }}-{{ mainloop.index }}-{{ loop.index }}-log" data-role="page">
430430
<div data-role="header" class="jqm-header">

0 commit comments

Comments
 (0)