Skip to content

Commit 340481d

Browse files
test: move to has_netplanlib() in test_networking.py (#6089)
1 parent 671baf2 commit 340481d

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

tests/integration_tests/test_networking.py

+17-14
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
JAMMY,
1818
NOBLE,
1919
)
20-
from tests.integration_tests.util import verify_clean_boot, verify_clean_log
20+
from tests.integration_tests.util import (
21+
has_netplanlib,
22+
verify_clean_boot,
23+
verify_clean_log,
24+
)
2125

2226
# Older Ubuntu series didn't read cloud-init.* config keys
2327
LXD_NETWORK_CONFIG_KEY = (
@@ -66,13 +70,13 @@ def test_skip(self, client: IntegrationInstance):
6670
client.execute(
6771
"mv /var/log/cloud-init.log /var/log/cloud-init.log.bak"
6872
)
69-
if CURRENT_RELEASE < JAMMY:
73+
if has_netplanlib(client):
74+
assert "Rendered netplan config using netplan python API" in log
75+
else:
7076
assert (
7177
"No netplan python module. Fallback to write"
7278
" /etc/netplan/50-cloud-init.yaml" in log
7379
)
74-
else:
75-
assert "Rendered netplan config using netplan python API" in log
7680
netplan = yaml.safe_load(
7781
client.execute("cat /etc/netplan/50-cloud-init.yaml")
7882
)
@@ -285,16 +289,7 @@ def test_invalid_network_v2_netplan(session_cloud: IntegrationCloud):
285289
"config_dict": config_dict,
286290
}
287291
) as client:
288-
# Netplan python API only available on JAMMY and later
289-
if CURRENT_RELEASE < JAMMY:
290-
assert (
291-
"Skipping netplan schema validation. No netplan API available"
292-
) in client.read_from_file("/var/log/cloud-init.log")
293-
assert (
294-
"Skipping network-config schema validation for version: 2."
295-
" No netplan API available."
296-
) in client.execute("cloud-init schema --system")
297-
else:
292+
if has_netplanlib(client):
298293
assert (
299294
"network-config failed schema validation! You may run "
300295
"'sudo cloud-init schema --system' to check the details."
@@ -307,6 +302,14 @@ def test_invalid_network_v2_netplan(session_cloud: IntegrationCloud):
307302
"# E1: Invalid netplan schema. Error in network definition:"
308303
" invalid boolean value 'badval"
309304
) in client.execute("cloud-init schema --system --annotate")
305+
else:
306+
assert (
307+
"Skipping netplan schema validation. No netplan API available"
308+
) in client.read_from_file("/var/log/cloud-init.log")
309+
assert (
310+
"Skipping network-config schema validation for version: 2."
311+
" No netplan API available."
312+
) in client.execute("cloud-init schema --system")
310313

311314

312315
@pytest.mark.skipif(PLATFORM != "ec2", reason="test is ec2 specific")

0 commit comments

Comments
 (0)