feat: return task result, not task

Author: samhotep

webapp/github.py

@@ -118,12 +118,11 @@ def get_repository_tree(self, repository: str, branch: str = "main"):
             raise
         for item in data["tree"]:
             if item["type"] == "blob" and item["path"].startswith("templates"):
-                task = async_save_file(
+                async_save_file(
                     tree_file_path=str(tree_file_path),
                     repository=repository,
                     path=item["path"],
                 )
-                task()
 
 
 @register_task()
@@ -140,19 +139,14 @@ def async_save_file(
         path (str): The remote path to the file inside the repository.
         tree_file_path (str): The local path where the file will be saved.
     """
-    try:
-        github = GitHub()
-        github.logger.info(f"File path {path}")
-        content = github.get_file_content(repository, path)
-        github.logger.info(f"File {path} downloaded")
-
-        file_path = Path(tree_file_path) / path
-        file_path.parent.mkdir(parents=True, exist_ok=True)
-
-        with file_path.open("wb") as file:
-            file.write(content)
-    except Exception as e:
-        github.logger.exception(f"Failed to save file: {e}")
+    github = GitHub()
+    content = github.get_file_content(repository, path)
+
+    file_path = Path(tree_file_path) / path
+    file_path.parent.mkdir(parents=True, exist_ok=True)
+
+    with file_path.open("wb") as file:
+        file.write(content)
 
 
 def init_github(app: flask.Flask) -> None:

webapp/tasks.py

@@ -1,6 +1,7 @@
 import functools
 import os
 from collections.abc import Callable
+from typing import Any
 
 from celery import current_app as celery_app
 
@@ -20,7 +21,7 @@ def outerwrapper(func: Callable) -> Callable:
             register_celery_task(func, celery_app=celery_app)
 
         @functools.wraps(func)
-        def wrapper(*args: tuple, **kwargs: dict) -> Callable:
+        def wrapper(*args: tuple, **kwargs: dict) -> Any:
             if os.getenv("REDIS_HOST"):
                 # Run the Celery task
                 task = run_celery_task(
@@ -39,11 +40,8 @@ def wrapper(*args: tuple, **kwargs: dict) -> Callable:
                     kwargs=kwargs,
                 )
 
-            # Start scheduled tasks
-            if delay:
-                task.delay(*args, **kwargs)
-
-            return task.delay
+            # Start task
+            return task.delay(*args, **kwargs)
 
         return wrapper