Skip to content

Security: dbus: investigate and mitigate command injection #208

Description

@artiepoole

Due to the way we are passing arguments along, we should be more careful in testing for side effects when a user tries to call dfx-mgr (or other future softeners).

I see a few tasks/options:

  • see how much of an issue this is
  • reimplement the dfx-mgr argument parser and require us to maintain it (burden) alongside dfx-mgr upstream
  • add fuzz testing
  • add side effect tests (try to get around the protections and create files or whatever other harmless, easily detected side effects can be produced and then test against them in future) whackamole style
  • rely on an external crate or otherwise get experienced eyes on this

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions