Issue is created on closure

[beliaev-maksim]

We have an integration between Jira and GitHub set on ubuntu.com and canonical.com. Everything works great except one thing.
Where there is an existing GitHub issue that can be closed right away I add a comment and close it by clicking on Close with comments. But this action creates a task in Jira.
Can you please remove the trigger for this particular case?
Currently I have to manually delete created Jira tasks after closing GitHub issues.
Thank you.

reporter: @akbarkz

[mr-cal]

I'm experiencing the same behavior.

After closing with a comment, re-opening and closing the issue will cause the bot to close the Jira task.

[beliaev-maksim]

the issue is not trivial to fix, the nature of the github app is that it must be stateless. GitHub sends two webhooks, one that the comment is created, next, that the issue is closed. Since the service is async, by the time when "issue closed" hook is processed, there is no issue created from a comment.

However, this is not a priority to fix (unless confirmed opposite) since

1. this issue will happen only on tickets that were never synced, meaning before the bot was added to the repo. With time all those tickets should disappear and closure will happen on synced tickets
2. there is a simpler workaround. First, you can comment, once it is synced, you close the ticket. (though, I acknowledge this is not the best UX we want)