[review] Address review feedback

- Restore missing 'starting' state check in VirtualBox current_state
- Fix VirtualBox current_state to detect stopped state immediately
- Remove duplicate TODO comment in wait_for_cloud_init
- Remove extra newline in wait_for_cloud_init
- Add if constexpr check to only treat IntentionalShutdownException
  as success for LaunchRequest, not StartRequest

Author: deepakshirkem

src/daemon/daemon.cpp

@@ -3567,12 +3567,18 @@ error_string mp::Daemon::async_wait_for_ssh_and_start_mounts_for(
                 vm->wait_for_cloud_init(timeout);
             }
         }
-        catch (const mp::IntentionalShutdownException&)
+        catch (const mp::IntentionalShutdownException& e)
         {
-            mpl::log(mpl::Level::info,
-                     name,
-                     "Instance powered off intentionally during initialization");
-            return {}; // Success - intentional shutdown
+            if constexpr (std::is_same_v<Request, LaunchRequest>)
+            {
+                mpl::log(mpl::Level::info, name,
+                        "Instance powered off intentionally during initialization");
+                return {}; // Success - intentional shutdown
+            }
+            else
+            {
+                throw StartException(name, "Unexpected shutdown during start");
+            }    
         }
 
         if (MP_SETTINGS.get_as<bool>(mp::mounts_key))

src/platform/backends/shared/base_virtual_machine.cpp

@@ -316,12 +316,12 @@ void mp::BaseVirtualMachine::wait_for_cloud_init(std::chrono::milliseconds timeo
             try_to_ssh();
             return mpu::TimeoutAction::retry;
         }
-        catch (const SSHExecFailure& e) // transitioning away from catching generic runtime errors                         
-        {                                // TODO remove once we're confident this is an anomaly
+        catch (const SSHExecFailure& e)                          
+        {                                
             return mpu::TimeoutAction::retry;
         }
-        catch (const std::exception& e)
-        {
+        catch (const std::exception& e) // transitioning away from catching generic runtime errors
+        {                               // TODO remove once we're confident this is an anomaly
             mpl::log_message(mpl::Level::warning, vm_name, e.what());
             return mpu::TimeoutAction::retry;
         }
@@ -330,7 +330,6 @@ void mp::BaseVirtualMachine::wait_for_cloud_init(std::chrono::milliseconds timeo
     auto on_timeout = [] {
         throw std::runtime_error("timed out waiting for initialization to complete");
     };
-
     mpu::try_action_for(on_timeout, timeout, action);
 }
 

src/platform/backends/virtualbox/virtualbox_virtual_machine.cpp

@@ -448,9 +448,9 @@ void mp::VirtualBoxVirtualMachine::suspend()
 mp::VirtualMachine::State mp::VirtualBoxVirtualMachine::current_state()
 {
     auto present_state = instance_state_for(name);
-    if (state == State::delayed_shutdown && present_state == State::running)
+    if ((state == State::delayed_shutdown && present_state == State::running) || state == State::starting)
         return state;
-
+        
     state = present_state;
     if (state == State::suspended || state == State::suspending)
         drop_ssh_session();